1900755 - webext-panels.xhtml's contentAreaContextMenu is missing showservicesmenu

Status: RESOLVED FIXED

(WebExtensions :: Frontend, task)

Description

[Tom Schuster (MoCo)]

Unlike its main-popupset.inc.xhtml counterpart, the contentAreaContextMenu menupop in webext-panels.xhtml is missing the showservicesmenu attribute.

From https://phabricator.services.mozilla.com/D211561

Comment 1

[Rob Wu [:robwu]]

The request for adding the showservicesmenu attribute originates from https://phabricator.services.mozilla.com/D211561?id=873707#inline-1176745

Is the Services menu item designed to work well with the extension sidebar? I have seen the Services menu item before but never used it. Is there any downside to resolving this bug by adding the showservicesmenu attribute in the referenced code?

Comment 2

[:Gijs (he/him)]

(In reply to Rob Wu [:robwu] from comment #1)

The request for adding the showservicesmenu attribute originates from https://phabricator.services.mozilla.com/D211561?id=873707#inline-1176745

Is the Services menu item designed to work well with the extension sidebar?

Not any worse than other text-selection or input-field related context menu items in the main context menu already are, I expect. It'd need some testing.

I have seen the Services menu item before but never used it. Is there any downside to resolving this bug by adding the showservicesmenu attribute in the referenced code?

Not that I'm aware of. It could do with some testing. At some point the Services (and Autofill) menu was added everywhere if there was any selection anywhere in the window, and this meant it started showing up in e.g. tabstrip context menus, which made no sense. So I changed it to be opt-in in bug 1858409 because this annoyed me. I opted in the main page context menu; I wasn't aware that the same context menu which we reuse in webextension sidebars doesn't actually have the same root node, otherwise I would probably have added it there immediately.

Comment 3

[Rob Wu [:robwu]]

I manually confirmed that the Services menu doesn't show up, and does show up with the showservicesmenu attribute and put up a patch at https://phabricator.services.mozilla.com/D214012.

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1900755 - Add showservicesmenu to webext-panels.html

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46afb94b9c63
Add showservicesmenu to webext-panels.html r=Gijs

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/46afb94b9c63