1900931 - Home and newtab pinned topsite icon contrast issue with dark wallpapers

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

Attachment: image(25).png

To test:

1. Set browser.newtabpage.activity-stream.newtabWallpapers.enabled to true
2. Set browser.newtabpage.activity-stream.newtabWallpapers.v2.enabled to true
3. Enter light mode.
4. Set a dark wallpaper
5. Pin a topsite tab
   Expected: The pin icon should match the topsite title text.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1900931 - Home and newtab fixing topsite pinned icon contrast with wallpaper

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/797ccb4e892f
Home and newtab fixing topsite pinned icon contrast with wallpaper r=home-newtab-reviewers,maxx

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/797ccb4e892f

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the steps from the description and can confirm that the "Pin" icon matches the "Top Site" title color.

That being said, during the bug fix verification, I have observed that the "Pin" icon is not clearly distinguishable from the highlight's background if a "Top Site" is hovered. However, I've logged a separate issue for this: Bug 1901511

Verified using the latest Firefox Nightly 128.0a1 (Build ID: 20240609205151) installed on Windows 10 x64, macOS 14.1.1, and Ubuntu 22.04 x64.