1900952 - [rustc 1.79] Perma error: field `rtl` is never read

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mh [at] glandium.org
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=461243744&repo=toolchains
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SHZjjPzERu-Kl-u8LETF-g/runs/0/artifacts/public/logs/live_backing.log

---

[task 2024-06-06T02:02:58.883Z] 02:02:58    ERROR -  error: field `rtl` is never read
[task 2024-06-06T02:02:58.883Z] 02:02:58     INFO -     --> toolkit/crashreporter/client/app/src/ui/model/mod.rs:340:9
[task 2024-06-06T02:02:58.883Z] 02:02:58     INFO -      |
[task 2024-06-06T02:02:58.884Z] 02:02:58     INFO -  337 | pub struct Application {
[task 2024-06-06T02:02:58.884Z] 02:02:58     INFO -      |            ----------- field in this struct
[task 2024-06-06T02:02:58.884Z] 02:02:58     INFO -  ...
[task 2024-06-06T02:02:58.885Z] 02:02:58     INFO -  340 |     pub rtl: bool,
[task 2024-06-06T02:02:58.885Z] 02:02:58     INFO -      |         ^^^
[task 2024-06-06T02:02:58.885Z] 02:02:58     INFO -      |
[task 2024-06-06T02:02:58.885Z] 02:02:58     INFO -      = note: `-D dead-code` implied by `-D warnings`
[task 2024-06-06T02:02:58.886Z] 02:02:58     INFO -      = help: to override `-D warnings` add `#[allow(dead_code)]`
[task 2024-06-06T02:02:58.934Z] 02:02:58    ERROR -  error: could not compile `crashreporter` (bin "crashreporter" test) due to 1 previous error

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1900952 - Mark the rtl field as dead code during tests.

Its only uses are in modules that aren't included during tests.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2508c446dffd
Mark the rtl field as dead code during tests. r=gsvelto

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/2508c446dffd

Comment 4

[Intermittent Failures Robot]

1 failures in 3649 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• toolchains: 1

Platform and build breakdown:

• macosx64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1900952&startday=2024-06-03&endday=2024-06-09&tree=all