1900984 - Ghost shadow on feature callout arrow when flip=slide makes the arrow disappear (MacOS)

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Shane Hughes [:aminomancer]]

When you move the window so that the callout would bleed off the screen's edge, it either flips or slides so it can stay on screen. When it slides, the arrow is configured to disappear, because sliding it over means the arrow would no longer be pointing to the right element. But when this happens on macOS, there's a spooky echo of the arrow's shadow because the -moz-window-shadow effect was apparently "locked in" and hiding the arrow does not re-render it. So you still get the same shadow as you had when the arrow was visible. We should do -moz-window-shadow: none to avoid this issue, and also because we're already applying a shadow anyway. So we're effectively doubling up on shadows on macOS.

Comment 1

[Hanna Alemu [:hanna_a]]

Attachment: shadowArrow.pmg

Comment 2

[Negin Sauermann]

Attachment: Bug 1900984 - Fix Ghost shadow on feature callout arrow when flip=slide makes the arrow disappear

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26147c627367
Fix Ghost shadow on feature callout arrow when flip=slide makes the arrow disappear r=omc-reviewers,mviar

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/26147c627367

Comment 5

[Negin Sauermann]

Note this only fixes the ghost shadow around the arrow icon but it's still apparent with the container - 1903841 addresses this.