1901089 - Cannot select task date unless "Start" or "Due Date" is checked (date picker can be opened but chosen date does not take effect)

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[Meichthys]

Steps to reproduce:

• Create a new task
• Change "Start" or "Due Date" date (without first checking box)

Another counter-intuative observation:

• Checking "Due Date" allows you to change the "Start" field, but checking the "Start" field does not allow you to change the "Due Date" field.

Actual results:

Date picker is shown, but after choosing date, the date will revert to the original date.

Expected results:

Chosen date should be entered into the field, and the checkbox should be automatically checked.

Comment 1

[Magnus Melin [:mkmelin]]

I can confirm that (on linux/daily).

Comment 2

[Ramona Gavrilescu]

Hello,
I have managed to reproduce this issue using 127.0b5(20240603175044) , 115.11.0(20240508141159) with MacOS 14.4.1 and Windows 10&11 using the same steps from the description.

I also tried to determine if this is a regression and went as far back as build 91.0a1(20210601105321) from 2021-06-01 and still managed to reproduce it with the same steps.

Comment 6

[Martin Schröder [:mschroeder]]

In bug 1731532 some code has been identified, which seems to be responsible for not disabling the date inputs, see https://searchfox.org/comm-central/source/calendar/base/content/item-editing/calendar-item-iframe.js#1291. aDatePickerId is no element but just the id. Also https://searchfox.org/comm-central/source/calendar/base/content/item-editing/calendar-item-iframe.js#1287 might be wrong then.

Comment 8

[Michael Weghorn]

Attachment: Bug 1901089: Disable date pickers when their checkboxes are unchecked. r=Fallen,darktrojan

The updateDateCheckboxes function contains logic
supposed to disable or enable the date/time pickers according
to the state of their corresponding checkboxes.

However, that logic wasn't working because
it tried to set a property directly on the ID of
the corresponding date/time picker element instead
of the actual element.

Make this actually work by retrieving the corresponding element
and setting its "disabled" property.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5a81c1541639
Disable date pickers when their checkboxes are unchecked. r=darktrojan