1901125 - [rustc-1.80] Perma tsan error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mh [at] glandium.org
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=461286259&repo=toolchains
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/U-cdygiMQTKq2jpGHUuwVw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2024-06-06T11:37:20.643Z] 11:37:20    ERROR -  error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[task 2024-06-06T11:37:20.643Z] 11:37:20     INFO -  Caused by:
[task 2024-06-06T11:37:20.643Z] 11:37:20     INFO -    patch for `gimli-0.28.1` in `https://github.com/rust-lang/crates.io-index` failed to resolve
[task 2024-06-06T11:37:20.643Z] 11:37:20     INFO -  Caused by:
[task 2024-06-06T11:37:20.644Z] 11:37:20     INFO -    The patch location `/builds/worker/fetches/rustc/lib/rustlib/src/rust/vendor/gimli-0.28.1` does not appear to contain any packages matching the name `gimli-0.28.1`.

Comment 1

[Intermittent Failures Robot]

1 failures in 3649 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• toolchains: 1

Platform and build breakdown:

• linux64: 1
  • tsan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1901125&startday=2024-06-03&endday=2024-06-09&tree=all

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1901125 - Properly handle the presence of multiple crates of the same name.

When building cargo sets up the patches for the vendored dependencies of
libstd, when several of those dependencies are different versions of the
same crate, only one of the corresponding patches work because the
package name, derived from the directory name, doesn't match.

Instead, we always take the package name from Cargo.toml.

While we're here, we add the missing resources on the rust-dev tasks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a4d857836a6
Properly handle the presence of multiple crates of the same name. r=firefox-build-system-reviewers,sergesanspaille

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4a4d857836a6