1901191 - Markup for privacy preserving attribution is using moz-support-link in an unintended way

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Francesco Lodolo [:flod]]

The markup includes a moz-support-link within the description, but that's removed by Fluent when applying the message, since the anchor is not a text-level element.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1901191 - Tweak use of moz-support-link in privacy-preserving setting, r=emilio!

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Can you elaborate? It seems to be preserved properly here, here's what I see on the inspector:

<description xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" class="indent tip-caption" data-l10n-id="website-advertising-private-attribution-description">This helps sites understand how their ads perform without collecting data about you. <html:a xmlns:html="http://www.w3.org/1999/xhtml" is="moz-support-link" class="learnMore" data-l10n-name="learn-more" support-page="privacy-preserving-attribution" href="https://support.mozilla.org/1/firefox/128.0a1/Darwin/en-US/privacy-preserving-attribution" target="_blank">Learn More</html:a></description>

Which looks right? Note the l10n-name stuff which should make it be preserved

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Can you elaborate? It seems to be preserved properly here, here's what I see on the inspector:

The anchor in the Fluent message is preserved, but the whole point of the moz-support-link component is to not have the learn more link explicitly defined in the message.

Right now, the moz-support-link in your code is not used at all.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

It is tho, right? Where does the href come from otherwise?

Comment 5

[Francesco Lodolo [:flod]]

In the hurry to find a fix, I provided a very poor analysis/explanation of the problem.

The current patch works, but it's adding unnecessary markup to the Fluent message that moz-support-link is designed to avoid.

website-advertising-private-attribution-description = This helps sites understand how their ads perform without collecting data about you. <a data-l10n-name="learn-more">Learn More</a>

I initially thought that this should create a duplicate link, but it isn't. Then I realized that the moz-support-link element is placed within the <description>, and assumed one of the links would be removed by Fluent at run-time. Instead, it's working because you're manually assigning the data-l10n-name to the anchor created by moz-support-link, so the anchor is preserved by DOM overlays.

    <html:a is="moz-support-link"
            class="learnMore"
            data-l10n-name="learn-more"
            support-page="privacy-preserving-attribution"/>

The correct approach with moz-support-link is to have it create the link, including the label. But for that to work, it needs to be outside of the element to which you're applying the Fluent message (otherwise, it will be removed by DOM overlays).

<description class="indent tip-caption">
    <html:span data-l10n-id="website-advertising-private-attribution-description" />
    <html:a is="moz-support-link"
            class="learnMore"
            support-page="privacy-preserving-attribution"/>
  </description>

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1901191 - Remove useless tail-with-learn-more class on <span>s. r=#settings-reviewers

It doesn't do anything on a span so it's just confusing.

Comment 7

[Phabricator Automation]

Comment on attachment 9406051 [details]
Bug 1901191 - Remove useless tail-with-learn-more class on <span>s. r=#settings-reviewers

Revision D212902 was moved to bug 1901194. Setting attachment 9406051 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91916bcb1740
Tweak use of moz-support-link in privacy-preserving setting, r=emilio,settings-reviewers

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/91916bcb1740