1901351 - Do not offer SelectTranslations Translate Link Text menu item for URLs

Status: VERIFIED FIXED

(Firefox :: Translations, enhancement, P3)

Description

[Erik Nordin [:nordzilla]]

Description

There are many cases in which the "Translate Link Text" option for the Select Translations Panel will be for a URL, rather than plain text that is hyperlinked.

If the linked text is verified to be just a URL, we should not offer to translate, because any translation on the URL would most likely yield an invalid URL.

If the user manually selects a URL, however, and choose to translate their active selection, rather than right clicking linked text, then we will still translate their selection regardless.

---

Steps to implement

• Modify the logic of the [https://searchfox.org/mozilla-central/rev/10e7fbf7a5a46e10b83becff0f16ffdedc9abe3d/browser/base/content/nsContextMenu.js#2610) function to not show the menu item if we are attempting to translate link text that is just a URL.

---

Tests to implement

• Write a test that ensures that the menu item is not available when right clicking link text that is a just a URL.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1901351 - Do not offer Translate Link Text for URLs r=#translations-reviewers!,ohall

This patch ensures that the Translate Link Text
option is not offered in the context menu when
right clicking hyperlinked text that would result
in translating a only a URL being translated.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3650bda33a8
Do not offer Translate Link Text for URLs r=translations-reviewers,ohall

Comment 4

[Cristian Tuns]

Backed out for causing bc failures in browser_contextmenu.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu.js | checking item #14 (context-translate-selection) name - Got "---", expected "context-translate-selection"

Comment 5

[Erik Nordin [:nordzilla]]

UPDATE

I ran the Translations test suite in try, but I forgot to check the general context-menu tests, which caused a failure.

I've now updated the relevant general context-menu tests.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b0e142ae4c1
Do not offer Translate Link Text for URLs r=translations-reviewers,ohall

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7b0e142ae4c1

Comment 8

[Erik Nordin [:nordzilla]]

Attachment: Bug 1901351 - Do not offer Translate Link Text for URLs

This patch ensures that the Translate Link Text
option is not offered in the context menu when
right clicking hyperlinked text that would result
in only a URL being translated.

Original Revision: https://phabricator.services.mozilla.com/D212980

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f7f9f18bfb67

Comment 10

[Daniel Bodea [:danibodea]]

I can reproduce this issue in Nightly v129.0a1 from 2024-06-10; I can confirm the fix in Nightly v129.0a1 from 2024-06-20 and Beta v128.0b5. The plain URL links (hyperlinks without representation text) no longer offer the option to translate in context menu. Closing as verified.