1901406 - Assertion failure: JS::StringIsASCII(message.get()), at /root/src/js/src/vm/ErrorReporting.cpp:56

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Nils Bars]

Attachment: bug.js

Steps to reproduce:

Checkout commit 15778b8c32f8535624fff2af36fc669e65a9af3 and invoke the js shell as follows:

/root/js-spidermonkey-shell  --fuzzing-safe  <testcase>

Actual results:

Assertion failure: JS::StringIsASCII(message.get()), at /root/src/js/src/vm/ErrorReporting.cpp:56

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This does not reproduce with the latest debug js shell from FTP (2015-10-21) since this early shell does not have listDir, but reproduces with m-c rev a5887514ddfb (Feb 2022).

listDir was added in m-c rev c430b858a795 in Feb 2020. Nicolas, you added this, is bug 1612515 a likely regressor?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1612515

Comment 3

[Nicolas B. Pierron [:nbp]]

Attachment: Bug 1901406 - JS Shell: os.file.listDir: Report UTF8 errors.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fa8df4224a7
JS Shell: os.file.listDir: Report UTF8 errors. r=arai

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing SM failures @ src/js/src/shell/OSObject.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/f52b1ed95074f73d237547af86ebf08006fdf416

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\self-test\bug1901406.js | [11368] Hit MOZ_CRASH(Could not close Find) at D:/task_171818809537131/src/js/src/shell/OSObject.cpp:512 (code 2147483651, args "")

Comment 6

[Nicolas B. Pierron [:nbp]]

(In reply to Sandor Molnar[:smolnar] from comment #5)

Failure log -> TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\self-test\bug1901406.js | [11368] Hit MOZ_CRASH(Could not close Find) at D:/task_171818809537131/src/js/src/shell/OSObject.cpp:512 (code 2147483651, args "")

For some reasons the windows error handling code was different, and did not check for error cases before creating the code which would attempt to close the non-open file, causing an error while closing, causing this assertion.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1da726c07b06
JS Shell: os.file.listDir: Report UTF8 errors. r=arai

Comment 8

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/1da726c07b06

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nbp, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Nicolas B. Pierron [:nbp]]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #9)

The patch landed in nightly and beta is affected.
:nbp, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Given that it only affect the shell version, I guess it can ride the train.