Closed Bug 1901489 Opened 25 days ago Closed 21 days ago

PromptListener "closed" event needs to include prompt type

Categories

(Remote Protocol :: Agent, enhancement, P2)

enhancement
Points:
3

Tracking

(firefox129 fixed)

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [webdriver:m11])

Attachments

(2 files, 3 obsolete files)

For both of the opened and closed events the PromptListener does not include the type of prompt, which makes it impossible for the closed event to determine which kind of prompt was open. As such we should add a promptType field under details to hand this information to the consumer of the event.

We actually don't need it for the open event given that it can easily be retrieved from the prompt.promptType property.

Summary: PromptListener "opened" and "closed" events need to include prompt type → PromptListener "closed" event needs to include prompt type
Points: --- → 3
Priority: -- → P2
Whiteboard: [webdriver:m11]
Attachment #9406405 - Attachment is obsolete: true
Attachment #9406626 - Attachment is obsolete: true
Attachment #9406623 - Attachment is obsolete: true
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/faedbd0638de
[browser] Return promptType in DOMModalDialogClosed event details. r=Gijs,tabbrowser-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/54d2d882de34
[remote] Return "promptType" in PromptListener "closed" events. r=webdriver-reviewers,Sasha
Attachment #9406623 - Attachment is obsolete: false

Comment on attachment 9406623 [details]
Bug 1901489 - [geckoview] Return promptType in details for DOMModalDialogClosed event.

Revision D213213 was moved to bug 1824220. Setting attachment 9406623 [details] to obsolete.

Attachment #9406623 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: