1901573 - The fxview-tab-list stories do not correctly render the meatball button

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Tim Giles [:tgiles]]

In the fxview-tab-list stories, there is a menu button that appears next to each row. However, the "..." icon is not being rendered due to a missing secondaryActionClass="options-button" in the story file. We should determine if this is the correct fix for this issue. If so, this would definitely be a good-first-bug.

Comment 1

[Tim Giles [:tgiles]]

Hey Kelly, do you recall the secondary action button being styled correctly in Storybook? Trying to determine if this has always been broken or if something regressed it. Seems like the quick fix is to throw secondaryActionClass="options-button" in the story file, but I don't know if that's the proper fix for this.
Thanks!

Comment 2

[Kelly Cochrane [:kcochrane]]

Hey, Tim! Yeah it was likely introduced here. You'd want to add secondaryActionClass of "options-button" for every variant except for the recently closed variant which would need a secondaryActionClass of "dismiss-button". Sorry we never caught that!

Comment 3

[Tim Giles [:tgiles]]

Just happened to stumble upon it when looking into something else, appreciate the quick response!

For the person who works on this bug:

• You will need to add secondaryActionClass to the Template in fxview-tab-list.stories.mjs
• You will need to add .secondaryActionClass=${secondaryActionClass} in the <fxview-tab-list> element
• You'll need to add secondaryActionClass: "options-button" to each variant's args except for the RecentlyClosed variant. That variant needs secondaryActionClass: "dismiss-button".

Feel free to needinfo me with any questions.

Comment 4

[BugBot [:suhaib / :marco]]

:nsharpley, since you are the author of the regressor, bug 1857298, could you take a look?

For more information, please visit BugBot documentation.

Comment 5

[Tim Giles [:tgiles]]

This is a regression only in Storybook, it's not a high priority fix. Clearing needinfo accordingly.

Nikki, if you want to fix this, then feel free to. Seems like a good-first-bug to me though (even if it is a regression technically).

Comment 6

[Nikki Sharpley (:nikkis) (she/her)]

This would be a great first bug! Thanks for flagging. All the info needed to sort it is above.

Comment 7

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1857298

Comment 8

[Isaac Lee]

Attachment: Bug 1901573 - The fxview-tab-list stories do not correctly render the meatball button. r?nsharpley!

Comment 9

[Isaac Lee]

Hi, I want to get involved with more contributions and I was wondering if there were any other bugs or projects that would be good for me to work on. Please let me know!

Comment 10

[Nikki Sharpley (:nikkis) (she/her)]

Hi Isaac, that's great to hear! A good place to start is searching with the keyword "good-first-bug". Here's a list of potential bugs Mozilla wide that might be good to work on: https://bugzilla.mozilla.org/buglist.cgi?keywords=good-first-bug&resolution=---&list_id=17113179

If there is a particular component that interests you more, you can narrow the search down by including that in the advanced search settings.

Side note, your patch is ready to land if you check back on Phabricator :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a190501fc81
The fxview-tab-list stories do not correctly render the meatball button. r=nsharpley

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4a190501fc81

Comment 13

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:lee.isaacy, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.