1901644 - Stop encapsulating CONSOLE_MESSAGE resource into a 'message' attribute

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Alexandre Poirot [:ochameau]]

The CONSOLE_MESSAGE resource is currently storing most of the message information into a distinct object, distinct from the resource object.
It is stored in the message attribute.
This slightly increase the RDP packet used when transmitting the console message.

DAMP reports some small improvement when applying such optimization:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=ee4e55174f1cbd635342810f66597f537e0a6f9b&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=de3fa5337b90d9c8695d8c64be1ac05e10283f5a&page=1&showOnlyConfident=1

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1901644 - [devtools] Uncapsulate CONSOLE_MESSAGE resource.

Comment 2

[Alexandre Poirot [:ochameau]]

See bug 1901643 comment 2, this patch doesn't seem to have a visible impact on DAMP.
The existing test may not be stressful enough. Or the time we spent in the UI may be too large to notice small framework improvement.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e661e5f38919
[devtools] Uncapsulate CONSOLE_MESSAGE resource. r=devtools-reviewers,nchevobbe

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/e661e5f38919

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Perfherder has detected a devtools performance change from push 295cccb04f0b3eeafbb4a86dd2fc1a72f86255ff.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
27%	damp console.log-in-loop-content-process-promise	windows10-64-shippable-qr	e10s fission stylo webrender	32.95 -> 41.92
23%	damp console.log-in-loop-content-process-promise	windows10-64-shippable-qr	e10s fission stylo webrender-sw	35.24 -> 43.35
10%	damp custom.webconsole.close.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	24.91 -> 27.28
9%	damp custom.webconsole.close.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	26.51 -> 28.91
9%	damp custom.webconsole.close.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	24.98 -> 27.24
8%	damp custom.webconsole.close.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	26.72 -> 28.90
7%	damp custom.webconsole.close.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	21.85 -> 23.35

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
10%	damp console.log-in-loop-content-process-date	linux1804-64-shippable-qr	e10s fission stylo webrender	39.48 -> 35.57
10%	damp console.log-in-loop-content-process-infinity	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	28.65 -> 25.85
9%	damp complicated.webconsole.close.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	12.85 -> 11.70
9%	damp console.log-in-loop-content-process-bigint	windows10-64-shippable-qr	e10s fission stylo webrender-sw	12.20 -> 11.13
9%	damp console.log-in-loop-content-process-bool	linux1804-64-shippable-qr	e10s fission stylo webrender	16.56 -> 15.13
...	...	...	...	...
4%	damp console.log-in-loop-content-process-typedarray	windows10-64-shippable-qr	e10s fission stylo webrender	36.49 -> 35.22

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 883

For more information on performance sheriffing please see our FAQ.