Avoid passing resourceType for each resource sent to the client
Categories
(DevTools :: Framework, enhancement)
Tracking
(firefox129 fixed)
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
For now, the framework layers in the server required to set the resourceType on each resource object.
But this ends up making the RDP packet to be larger and also prevents having the resource objects to be arrays.
Some small performance improvement is reported by DAMP:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=de3fa5337b90d9c8695d8c64be1ac05e10283f5a&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=7e492d1bdcae79670ebdb62d7ecc764ffb9089d7&page=1&showOnlyConfident=1
This should hopefully combine well with bug 1900982 and provide even faster tracer performance.
That by allowing to have the tracer subtypes become resources and be handled by the framework.
|
Assignee | |
Comment 1•3 months ago
|
||
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 2•3 months ago
|
||
While this prevents a massive regression when landing bug 1902229, this change doesn't seem to have a visible impact in DAMP.
On mozilla-central, the tracer still uses its own throttling and only emit a couple of resources per second. Each resources containing thousands of traces.
When landing bug 1902229, the tracer will start emitting thousands of resources.
Here is the perf compare against mozilla central, which also bundles bug 1901644:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=608bc58d44b892e49ae68f34b03204023d6f33b3&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=ef7bb21cfcba2e00d5d52390c004743e3723b9d0&page=1&showOnlyConfident=1
It has an impact, but very surprising to see it appear on source-map...
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aca16d81755d [devtools] Gather resources in arrays in order to prevent having to pass the resource type everytime. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
Description
•