1901905 - [rustc 1.80] Perma error: struct `Promise` is never constructed

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mh [at] glandium.org
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=461912299&repo=toolchains
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GXlboh_YRY6XSjuxysW1dw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2024-06-11T21:25:39.030Z] 21:25:39    ERROR -  error: struct `Promise` is never constructed
[task 2024-06-11T21:25:39.030Z] 21:25:39     INFO -    --> xpcom/rust/xpcom/src/promise.rs:26:12
[task 2024-06-11T21:25:39.031Z] 21:25:39     INFO -     |
[task 2024-06-11T21:25:39.031Z] 21:25:39     INFO -  26 | pub struct Promise {
[task 2024-06-11T21:25:39.032Z] 21:25:39     INFO -     |            ^^^^^^^
[task 2024-06-11T21:25:39.032Z] 21:25:39     INFO -     |
[task 2024-06-11T21:25:39.032Z] 21:25:39     INFO -     = note: `-D dead-code` implied by `-D warnings`
[task 2024-06-11T21:25:39.032Z] 21:25:39     INFO -     = help: to override `-D warnings` add `#[allow(dead_code)]`
[task 2024-06-11T21:25:39.033Z] 21:25:39    ERROR -  error: function `DomPromise_AddRef` is never used
[task 2024-06-11T21:25:39.033Z] 21:25:39     INFO -    --> xpcom/rust/xpcom/src/promise.rs:18:16
[task 2024-06-11T21:25:39.033Z] 21:25:39     INFO -     |
[task 2024-06-11T21:25:39.034Z] 21:25:39     INFO -  18 |         pub fn DomPromise_AddRef(promise: *const Promise);
[task 2024-06-11T21:25:39.034Z] 21:25:39     INFO -     |                ^^^^^^^^^^^^^^^^^
[task 2024-06-11T21:25:39.034Z] 21:25:39    ERROR -  error: function `DomPromise_Release` is never used
[task 2024-06-11T21:25:39.034Z] 21:25:39     INFO -    --> xpcom/rust/xpcom/src/promise.rs:19:16
[task 2024-06-11T21:25:39.034Z] 21:25:39     INFO -     |
[task 2024-06-11T21:25:39.035Z] 21:25:39     INFO -  19 |         pub fn DomPromise_Release(promise: *const Promise);
[task 2024-06-11T21:25:39.035Z] 21:25:39     INFO -     |                ^^^^^^^^^^^^^^^^^^
[task 2024-06-11T21:25:39.035Z] 21:25:39    ERROR -  error: function `DomPromise_RejectWithVariant` is never used
[task 2024-06-11T21:25:39.035Z] 21:25:39     INFO -    --> xpcom/rust/xpcom/src/promise.rs:20:16
[task 2024-06-11T21:25:39.036Z] 21:25:39     INFO -     |
[task 2024-06-11T21:25:39.036Z] 21:25:39     INFO -  20 |         pub fn DomPromise_RejectWithVariant(promise: *const Promise, variant: *const nsIVariant);
[task 2024-06-11T21:25:39.036Z] 21:25:39     INFO -     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-06-11T21:25:39.037Z] 21:25:39    ERROR -  error: function `DomPromise_ResolveWithVariant` is never used
[task 2024-06-11T21:25:39.037Z] 21:25:39     INFO -    --> xpcom/rust/xpcom/src/promise.rs:21:16
[task 2024-06-11T21:25:39.037Z] 21:25:39     INFO -     |
[task 2024-06-11T21:25:39.038Z] 21:25:39     INFO -  21 |         pub fn DomPromise_ResolveWithVariant(promise: *const Promise, variant: *const nsIVariant);
[task 2024-06-11T21:25:39.038Z] 21:25:39     INFO -     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1901905 - Mark xpcom::Promise as allowed dead code.

Rustc 1.80 complains it's dead code because it's never constructed, but
it's a type that is constructed from the C++'s end.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81380415b358
Mark xpcom::Promise as allowed dead code. r=xpcom-reviewers,emilio

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/81380415b358

Comment 4

[Intermittent Failures Robot]

1 failures in 4625 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• toolchains: 1

Platform and build breakdown:

• osx-cross: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1901905&startday=2024-06-10&endday=2024-06-16&tree=all