1901945 - Can't go back to bug number page in the browser history after clicking on the "Add reminder" button

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Pascal Chevrel:pascalc (PTO until Sept 2)]

STR:
1 Go to a bug number like https://bugzilla.mozilla.org/show_bug.cgi?id=1894968
2 Click on the "Add reminder" button -> https://bugzilla.mozilla.org/userprefs.cgi?tab=reminders&bug_id=1894968
3 Go back to https://bugzilla.mozilla.org/show_bug.cgi?id=1894968 by clicking on the back button n your browser

ER:
Land to https://bugzilla.mozilla.org/show_bug.cgi?id=1894968

AR:
Land on the page I was before https://bugzilla.mozilla.org/show_bug.cgi?id=1894968

Comment 1

[:glob ✱]

https://github.com/mozilla-bteam/bmo/blob/842c7a6cb850c0e259ffb7a2acf17d9f7240bd71/extensions/BugModal/web/bug_modal.js#L923 is the problem; it should be assigning to location.href not calling location.replace().

Also, this function is async unnecessarily, and query strings shouldn't contain spaces:

- query_string += "&note=Needinfo requested by " + encodeURIComponent(has_needinfo_from);
+ query_string += "&note=" + encodeURIComponent("Needinfo requested by " + has_needinfo_from);

Comment 2

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1901945 - Can't go back to bug number page in the browser history after clicking on the Add reminder button (#2258)

Comment 3

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/8c0295a019b2ffe72ac61f736f59aff24b1f5152