1902056 - Update strings for Sidebar toolbarbutton, close button and Customize Sidebar visibility settings

Status: RESOLVED FIXED

(Firefox :: Sidebar, task, P1)

Description

[Jonathan Sudiaman [:jsudiaman]]

Tooltip text should be Expand sidebar or Collapse sidebar depending on its current state.

Comment 1

[Stuart Colville [:muffinresearch]]

Hi Katie, just checking to see if you have thoughts on how we could refine what the tool-tips say based on the sidebar settings state?

Comment 2

[klower]

Hi Stuart - You can see the tooltips in the PRD, sidebar keyboard shortcuts section: https://docs.google.com/document/d/1V7rp3KdokSrcStDgL60qLlsFY3T00rqLf1lyr9q7e9U/edit?usp=sharing

Looking at Transvision, it seems the shortcuts themselves are stored elsewhere - so (%S) means to pull in the appropriate shortcut and place it in parenthesis.

Hovering on the New Tab icon when in horizontal tabs is a good example of the style to model.

Open a new tab (⌘T)

Comment 3

[Ania]

Here's the link to the updated tooltip string:
https://docs.google.com/document/d/1V7rp3KdokSrcStDgL60qLlsFY3T00rqLf1lyr9q7e9U/edit#heading=h.papfi5yxmqb1

Comment 4

[Sarah Clements [:sclements]]

While we're making string changes, let's also add a "Close" tooltip to the close button used in the different panels.

Comment 6

[klower]

Hi Jonathan - Please see this frame in Figma for a visual of the changes, as well as the final strings for the "Customize Sidebar visibility settings" part of this ticket: https://www.figma.com/design/ZFavpnAJee39j2mFf8U3D0/Sidebar-UX-Spec?node-id=14294-160500&t=QEkEzdDBotsGuEs8-4

To summarize the string changes:
"Sidebar settings" is not needed / present as a string in the UI anymore
Section header "Sidebar button" is a new string
"Always show" string changes to "Expand and collapse sidebar"
"Hide sidebar" string changes to "Show and hide sidebar"
Section header "Sidebar position" is a new string

If any questions please let me know - TY!

Comment 7

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1902056 - Update strings for Sidebar toolbarbutton, close button and Customize Sidebar visibility settings r?#sidebar-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef1b42c36db7
Update strings for Sidebar toolbarbutton, close button and Customize Sidebar visibility settings r=sidebar-reviewers,fluent-reviewers,sclements,bolsson

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ef1b42c36db7

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing perma bc failures @ browser_toolbarKeyNav.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/86360951a48a3b538013066d76ae93425a27216b

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/keyboard/browser_toolbarKeyNav.js | Test timed out

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/896edf9e22ed
Update strings for Sidebar toolbarbutton, close button and Customize Sidebar visibility settings r=sidebar-reviewers,fluent-reviewers,sclements,bolsson

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/896edf9e22ed