Closed Bug 1902342 Opened 1 year ago Closed 10 months ago

Bookmarks Toolbar briefly shows placeholder message ("For quick access, place your bookmarks here...") on every new Firefox window, sometimes alongside my first bookmark

Categories

(Firefox :: Bookmarks & History, defect, P3)

Product:
Firefox
Component:
Bookmarks & History
Version:
Firefox 131
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
132 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- wontfix
firefox-esr128 --- wontfix
firefox129 --- wontfix
firefox130 --- wontfix
firefox131 --- wontfix
firefox132 --- verified
firefox133 --- verified
firefox134 --- verified

People

(Reporter: dholbert, Assigned: mak)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [sng])

Attachments

(5 files)

screenshot of bug (placeholder message briefly displayed in new window, alongside an actual bookmark)
43.57 KB, image/jpeg
Details
screencast where the bug reproduces in a fresh profile (extremely briefly, you might need to watch in slow-motion or drag scrubber while video is paused to see it)
983.77 KB, video/webm
Details
screenshot of a moment in the screencast where the bug can be seen
95.72 KB, image/png
Details
Consistently flashing bookmarks toolbar
177.70 KB, video/webm
Details
Bug 1902342 - Bookmarks Toolbar empty message flickers with opening new windows. r=daisuke
48 bytes, text/x-phabricator-request
Details | Review

STR:

  1. (optional but encouraged) Start some screen recording software, to play back later in slow-motion, to increase the likelihood of seeing the very-brief issue.
  2. Configure Firefox to show the bookmarks toolbar, and place some bookmarks on it. (I have 5 bookmarks on it, the first of which is Spotify, and in my case I have it set to only-show-on-new-tab.)
  3. Open a new Firefox window, and watch its bookmarks-toolbar very closely.

ACTUAL RESULTS:

  • The new Firefox Window's bookmarks-toolbar briefly renders with this placeholder message:
For quick access, place your bookmarks here on the bookmarks toolbar.  _Manage bookmarks..._
  • In my case, this actually rendered alongside my first bookmark, which seems bizarre & like something that should never happen.

EXPECTED RESULTS:

  • The placeholder message should never be displayed simultaneously with an actual bookmark.
  • If we have bookmarks on the bookmarks toolbar, we should never display the placeholder message inviting the user to place bookmarks there (since they already have done that). (Even if we're stalled discovering what-the-actual-bookmarks-are, it seems like we could track the fact that they exist in some sort of lightweight quick-to-discover sort of way, and query that when deciding whether to show this message). If we display it, it's pretty disconcerting because it's a lot of text that we flash for just a moment, which makes it feel to the user like they just missed a message of some sort
Attachment #9407277 - Attachment description: screenshot → screenshot of bug (placeholder message briefly displayed in new window, alongside an actual bookmark)

I can reproduce this bug in a fresh profile, though I think you need to remove the "Import bookmarks" button from the bookmarks-toolbar (the leftmost thing on it) before this reproduces. At least, I wasn't able to see this placeholder message appearing on new windows until I removed that button.

If it matters: I'm testing with Nightly 129.0a1 (2024-06-13) (64-bit) on Linux (though I don't currently have any reason to believe that this would be platform-depenent).

Attachment #9407310 - Attachment description: screencast where the bug reproduces in a fresh profile (extremely briefly, you might need to watch in slow-motion or drag scrubber while video is pausedto see it) → screencast where the bug reproduces in a fresh profile (extremely briefly, you might need to watch in slow-motion or drag scrubber while video is paused to see it)

Here's a screenshot from my just-attached screencast where the bug can be seen, for the second new-window that I open in the screencast. (The first new-window in the screencast seems to be fine, though I suspect that's just luck / raciness.)

Looks like this placeholder message was added in bug 1674091, in part as a way to "prop up" the height of the toolbar when it's empty.

One possible hackaround here is that we could make the message be initially visibility:hidden or something, so that it takes up vertical space but doesn't paint (to avoid the perception of "wait, what was the big message that Firefox just flashed at me for a moment").

That's still not really ideal/complete, though, because that wouldn't fix the problem where an actual bookmark (e.g. "Get Involved" in my just-attached attachment 1902342) is being drawn at the completely-wrong-location (way over on the right side) for a few frames as the window appears.

Depends on: 1674091

(In reply to Daniel Holbert [:dholbert] from comment #4)

One possible hackaround here is that we could make the message be initially visibility:hidden or something, so that it takes up vertical space but doesn't paint (to avoid the perception of "wait, what was the big message that Firefox just flashed at me for a moment").

Yep, I think that'd be a reasonable approach.
To avoid the bookmark shifting we could maybe temporarily set the width of the message box to 0

I doubt we may have time to investigate this shortly, but we'd surely evaluate patches.

Severity: -- → S4
Priority: -- → P3

(In reply to Daniel Holbert [:dholbert] from comment #4)

Looks like this placeholder message was added in bug 1674091, in part as a way to "prop up" the height of the toolbar when it's empty.

One possible hackaround here is that we could make the message be initially visibility:hidden or something, so that it takes up vertical space but doesn't paint (to avoid the perception of "wait, what was the big message that Firefox just flashed at me for a moment").

That's still not really ideal/complete, though, because that wouldn't fix the problem where an actual bookmark (e.g. "Get Involved" in my just-attached attachment 1902342) is being drawn at the completely-wrong-location (way over on the right side) for a few frames as the window appears.

Yeah, IIRC at some point we used width: 0 and visible overflow to help with that but that also didn't work because then the link wasn't clickable. ( bug 1812636). Maybe it'd be OK as a transient state? There's been a lot of iteration on exactly how this message works - basically the async-ness here makes it difficult. It's gotten to a point where I feel like rewriting the implementation may be easier than trying to bolt yet another thing on top (as Emilio's comment on that patch says, it's not clear why we need this much logic / CSS for what would appear to be a simple enough message).

That said, although this might be difficult to avoid for the initial window, avoiding it for the Nth window case should be easier as we could have a sync cache of whether there are bookmarks there?

Anyway, yeah, the requirements for this message ideally are:

  • take up the same height as a single bookmark before deciding whether to show it, as the bookmarks toolbar is visible and shouldn't flicker or lead to web content being resized when it populates
  • allow drag/drop of bookmarks (links) to the entire bookmark bar when visible
  • the link should be clickable/functional
  • the message should be announced to screen reader users the first time it's visible ( bug 1886807 )
  • not be visible / take up width until/unless we know there aren't bookmarks
  • shouldn't synchronously load / block on bookmarks being read (esp. for the first window / startup)

hopefully that's it and I've not forgotten anything...

(In reply to :Gijs (he/him) from comment #6)

It's gotten to a point where I feel like rewriting the implementation may be easier than trying to bolt yet another thing on top

It should probably be implemented as a toolbar placeholder message, and managed by the toolbar widget itself. Though it seems hard to justify time (and risk) spent on another rewrite of it.
The code has already been simplified a bit by Emilio and me.

That said, although this might be difficult to avoid for the initial window, avoiding it for the Nth window case should be easier

Sure, we could pass the information when opening new windows, if the current window has already completed toolbar init.
And use that info somewhere around here, I guess https://searchfox.org/mozilla-central/rev/d31f750ad9e5b6c8f7b62d387dbea3f804044350/browser/base/content/browser-places.js#1523,1567
Though that same code could also manage to hide the text until we know whether it's necessary to show it, and that should just work for any window without the need to pass info around.

This video shows the consistency of the issue, the bookmarks toolbar flashes with placeholder text every time a new window is opened.

it's not unlikely, considered various stuff had to become async to avoid effective performance concerns.

Apart from passing already-known info to new windows, the other things to investigate is why personal-toolbar-empty appear when it's supposed to be hidden true initially.

Edit: hm it looks like initially we may assume checkNumBookmarksOnToolbar false, and then re-evaluate, because "initialized" attribute is set before the second evaluation, we show the text for a brief moment:

        // If the bookmarks are here but it's early in startup, show the
        // message. It'll get made visibility: hidden early in startup anyway -
        // it's just to ensure the toolbar has height.

So there's a few things: "initialized" should probably be set later, once the status is stable. Sometimes we can determine the status immediately, other times we must count bookmarks. When "initialized" is not yet set, we still want to uncollapse the text, but use visibility:hidden on it to keep the toolbar height. Then there's the "nowidth" attribute that is unclear how much is necessary.

Assignee: nobody → mak
Status: NEW → ASSIGNED
Whiteboard: [sng]
Attachment #9420663 - Attachment description: WIP: Bug 1902342 - Bookmarks Toolbar briefly shows placeholder message on new windows → Bug 1902342 - Bookmarks Toolbar empty message flickers with opening new windows. r=daisuke
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/db80e52c6f44 Bookmarks Toolbar empty message flickers with opening new windows. r=daisuke,desktop-theme-reviewers,places-reviewers,dao

Backed out for causing mochitest failures on browser_UsageTelemetry_interaction.js.

[task 2024-09-02T17:14:38.970Z] 17:14:38     INFO - TEST-START | browser/modules/test/browser/browser_UsageTelemetry_interaction.js
[task 2024-09-02T17:14:38.985Z] 17:14:38     INFO - GECKO(3260) | [Parent 6764, Main Thread] WARNING: NS_ENSURE_TRUE(mNameHashtable.Get(aName, &index)) failed: file /builds/worker/checkouts/gecko/storage/mozStorageRow.cpp:91
[task 2024-09-02T17:14:39.012Z] 17:14:39     INFO - GECKO(3260) | [Child 7636: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 1f91b3cd800 == 1 [pid = 7636] [id = 0]
[task 2024-09-02T17:14:39.012Z] 17:14:39     INFO - GECKO(3260) | [Child 7636: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (1f92260d600) [pid = 7636] [serial = 1] [outer = 0]
[task 2024-09-02T17:14:39.013Z] 17:14:39     INFO - GECKO(3260) | [Child 7636: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (1f91b3d0000) [pid = 7636] [serial = 2] [outer = 1f92260d600]
[task 2024-09-02T17:14:39.097Z] 17:14:39     INFO - GECKO(3260) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to C:\Users\task_172529643569395\AppData\Local\Temp\tmpjmqq69br.mozrunner\runtests_leaks_tab_pid2524.log
[task 2024-09-02T17:14:39.111Z] 17:14:39     INFO - GECKO(3260) | [Parent 6764, Main Thread] WARNING: BounceTrackingState::OnDocumentStartRequest failed.: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/netwerk/ipc/DocumentLoadListener.cpp:2612
[task 2024-09-02T17:14:39.120Z] 17:14:39     INFO - GECKO(3260) | [Child 7636: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (1f91b3d4000) [pid = 7636] [serial = 3] [outer = 1f92260d600]
[task 2024-09-02T17:14:39.323Z] 17:14:39     INFO - GECKO(3260) | console.error: CustomizableUI:
[task 2024-09-02T17:14:39.323Z] 17:14:39     INFO - GECKO(3260) |   Could not localize property '12foo.tooltiptext'.
[task 2024-09-02T17:14:39.352Z] 17:14:39     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 26a8b7c6800 == 4 [pid = 7292] [id = 20]
[task 2024-09-02T17:14:39.353Z] 17:14:39     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (26a86a82400) [pid = 7292] [serial = 51] [outer = 0]
[task 2024-09-02T17:14:39.354Z] 17:14:39     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 9 (26a8b7c7800) [pid = 7292] [serial = 52] [outer = 26a86a82400]
[task 2024-09-02T17:14:39.399Z] 17:14:39     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 10 (26a90f03c00) [pid = 7292] [serial = 53] [outer = 26a86a82400]
[task 2024-09-02T17:14:39.502Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (1dcac2fd000) [pid = 7628] [serial = 61] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:39.503Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 13 (1dcae71c800) [pid = 7628] [serial = 68] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:39.503Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (1dcae718800) [pid = 7628] [serial = 66] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:39.505Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (1dcac2fe400) [pid = 7628] [serial = 64] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:39.505Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (1dcac2fb400) [pid = 7628] [serial = 63] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:39.506Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1dcae71bc00 == 3 [pid = 7628] [id = 26] [url = about:blank]
[task 2024-09-02T17:14:39.507Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1dcac2f9400 == 2 [pid = 7628] [id = 27] [url = about:blank]
[task 2024-09-02T17:14:39.507Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1dcac2fd800 == 1 [pid = 7628] [id = 28] [url = about:blank]
[task 2024-09-02T17:14:39.536Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (1dca4582c00) [pid = 7628] [serial = 70] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:39.537Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (1dcae01c200) [pid = 7628] [serial = 73] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:39.538Z] 17:14:39     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (1dcae01be00) [pid = 7628] [serial = 67] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:39.778Z] 17:14:39     INFO - GECKO(3260) | [WARN  webrender::renderer::init] asking to enable_gpu_markers but no supporting extension was found
[task 2024-09-02T17:14:39.805Z] 17:14:39     INFO - GECKO(3260) | [Parent 6764, Main Thread] WARNING: NS_ENSURE_TRUE(weakFrame.IsAlive()) failed: file /builds/worker/checkouts/gecko/layout/xul/nsXULPopupManager.cpp:1434
[task 2024-09-02T17:14:39.875Z] 17:14:39     INFO - GECKO(3260) | [Parent 6764, Main Thread] WARNING: Suboptimal indexes for the SQL statement 0x1cd6aec5440 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp:113
[task 2024-09-02T17:14:39.920Z] 17:14:39     INFO - GECKO(3260) | [Parent 6764, Main Thread] WARNING: NS_ENSURE_TRUE(mNameHashtable.Get(aName, &index)) failed: file /builds/worker/checkouts/gecko/storage/mozStorageRow.cpp:91
[task 2024-09-02T17:14:40.095Z] 17:14:40     INFO - GECKO(3260) | [Child 9116: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (22944514c00) [pid = 9116] [serial = 31] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:40.097Z] 17:14:40     INFO - GECKO(3260) | [Child 9116: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (2293edeb800) [pid = 9116] [serial = 30] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:40.098Z] 17:14:40     INFO - GECKO(3260) | [Child 9116: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (2293ede8800) [pid = 9116] [serial = 28] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:40.382Z] 17:14:40     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 47 (1cd63267c00) [pid = 6764] [serial = 174] [outer = 0] [url = about:mozilla]
[task 2024-09-02T17:14:40.383Z] 17:14:40     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 46 (1cd638cd000) [pid = 6764] [serial = 187] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:40.383Z] 17:14:40     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 45 (1cd59be2000) [pid = 6764] [serial = 180] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:40.385Z] 17:14:40     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cd5961c000 == 14 [pid = 6764] [id = 85] [url = about:mozilla]
[task 2024-09-02T17:14:40.403Z] 17:14:40     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cd62be9800 == 13 [pid = 6764] [id = 91] [url = about:blank]
[task 2024-09-02T17:14:41.119Z] 17:14:41     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 44 (1cd59af0000) [pid = 6764] [serial = 179] [outer = 0] [url = about:mozilla]
[task 2024-09-02T17:14:41.120Z] 17:14:41     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 43 (1cd62ebc600) [pid = 6764] [serial = 186] [outer = 0] [url = about:robots]
[task 2024-09-02T17:14:42.099Z] 17:14:42     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 26a8b7c4400 == 3 [pid = 7292] [id = 17] [url = about:blank]
[task 2024-09-02T17:14:42.099Z] 17:14:42     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 26a8b7c0800 == 2 [pid = 7292] [id = 18] [url = about:blank]
[task 2024-09-02T17:14:42.100Z] 17:14:42     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 26a8b7c3000 == 1 [pid = 7292] [id = 19] [url = about:blank]
[task 2024-09-02T17:14:42.100Z] 17:14:42     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 26a8b7c6800 == 0 [pid = 7292] [id = 20] [url = about:blank]
[task 2024-09-02T17:14:42.150Z] 17:14:42     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (26a86a7f400) [pid = 7292] [serial = 46] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:42.151Z] 17:14:42     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (26a86a82400) [pid = 7292] [serial = 51] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:42.152Z] 17:14:42     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (26a86a83000) [pid = 7292] [serial = 49] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:42.152Z] 17:14:42     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (26a86a82000) [pid = 7292] [serial = 44] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:42.318Z] 17:14:42     INFO - GECKO(3260) | [Child 2648: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (1f035335400) [pid = 2648] [serial = 45] [outer = 0] [url = about:newtab]
[task 2024-09-02T17:14:42.319Z] 17:14:42     INFO - GECKO(3260) | [Child 2648: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (1f03347d400) [pid = 2648] [serial = 44] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:42.319Z] 17:14:42     INFO - GECKO(3260) | [Child 2648: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (1f02bcedc00) [pid = 2648] [serial = 47] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:42.320Z] 17:14:42     INFO - GECKO(3260) | [Child 2648: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1f02bcecc00 == 1 [pid = 2648] [id = 16] [url = about:newtab]
[task 2024-09-02T17:14:42.385Z] 17:14:42     INFO - GECKO(3260) | [Child 2648: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (1f029582200) [pid = 2648] [serial = 46] [outer = 0] [url = about:newtab]
[task 2024-09-02T17:14:43.684Z] 17:14:43     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (1dcae71d800) [pid = 7628] [serial = 69] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:43.685Z] 17:14:43     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (1dcae71cc00) [pid = 7628] [serial = 75] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:43.686Z] 17:14:43     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (1dcac2fe000) [pid = 7628] [serial = 74] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:43.687Z] 17:14:43     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (1dcac2fc800) [pid = 7628] [serial = 72] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:43.687Z] 17:14:43     INFO - GECKO(3260) | [Child 7628: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (1dcac2fa000) [pid = 7628] [serial = 71] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:45.099Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cd595d8c00 == 12 [pid = 6764] [id = 80] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:45.100Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cd619d2800 == 11 [pid = 6764] [id = 86] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:45.100Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cd61fbe400 == 10 [pid = 6764] [id = 83] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:45.101Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cd6326b400 == 9 [pid = 6764] [id = 88] [url = about:robots]
[task 2024-09-02T17:14:45.102Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cd595dc800 == 8 [pid = 6764] [id = 75] [url = chrome://browser/content/webrtcIndicator.xhtml]
[task 2024-09-02T17:14:45.103Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cd595da800 == 7 [pid = 6764] [id = 90] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:45.103Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cd5cb76c00 == 6 [pid = 6764] [id = 89] [url = about:blank]
[task 2024-09-02T17:14:45.104Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cd59be9c00 == 5 [pid = 6764] [id = 78] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:45.104Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 42 (1cd5cb81400) [pid = 6764] [serial = 190] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:45.105Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 41 (1cd638d0800) [pid = 6764] [serial = 188] [outer = 0] [url = about:robots]
[task 2024-09-02T17:14:45.105Z] 17:14:45     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 40 (1cd605bd800) [pid = 6764] [serial = 181] [outer = 0] [url = about:mozilla]
[task 2024-09-02T17:14:46.296Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 39 (1cd6228ac00) [pid = 6764] [serial = 162] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.297Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 38 (1cd6601c400) [pid = 6764] [serial = 170] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.297Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 37 (1cd63d82800) [pid = 6764] [serial = 184] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.298Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 36 (1cd67332a00) [pid = 6764] [serial = 177] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.302Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 35 (1cd4c171e00) [pid = 6764] [serial = 194] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.303Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 34 (1cd5ff77200) [pid = 6764] [serial = 175] [outer = 0] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:46.304Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 33 (1cd4c170400) [pid = 6764] [serial = 192] [outer = 0] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:46.304Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 32 (1cd5c67f600) [pid = 6764] [serial = 164] [outer = 0] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:46.305Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 31 (1cd5ce8c800) [pid = 6764] [serial = 154] [outer = 0] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:46.306Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 30 (1cd59af3400) [pid = 6764] [serial = 182] [outer = 0] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:46.307Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 29 (1cd5ce92e00) [pid = 6764] [serial = 160] [outer = 0] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:46.307Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 28 (1cd4c16ec00) [pid = 6764] [serial = 168] [outer = 0] [url = chrome://browser/content/browser.xhtml]
[task 2024-09-02T17:14:46.308Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 27 (1cd4c172600) [pid = 6764] [serial = 158] [outer = 0] [url = chrome://browser/content/webrtcIndicator.xhtml]
[task 2024-09-02T17:14:46.309Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 26 (1cd6a050e00) [pid = 6764] [serial = 166] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.310Z] 17:14:46     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (26a8b7c2400) [pid = 7292] [serial = 47] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.311Z] 17:14:46     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (26a8b7c4000) [pid = 7292] [serial = 48] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.311Z] 17:14:46     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (26a90f03c00) [pid = 7292] [serial = 53] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.312Z] 17:14:46     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (26a8b7c5c00) [pid = 7292] [serial = 50] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.312Z] 17:14:46     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (26a8b7c4c00) [pid = 7292] [serial = 45] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.313Z] 17:14:46     INFO - GECKO(3260) | [Child 7292: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (26a8b7c7800) [pid = 7292] [serial = 52] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.314Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 25 (1cd4c171200) [pid = 6764] [serial = 189] [outer = 0] [url = about:restartrequired?e=restartrequired&u=about%3Ablank&c=UTF-8&d=%20]
[task 2024-09-02T17:14:46.526Z] 17:14:46     INFO - GECKO(3260) | [Child 2648: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (1f03347cc00) [pid = 2648] [serial = 48] [outer = 0] [url = about:newtab]
[task 2024-09-02T17:14:46.915Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 24 (1cd63269800) [pid = 6764] [serial = 167] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.917Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 23 (1cd5961dc00) [pid = 6764] [serial = 159] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.917Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 22 (1cd5f47d000) [pid = 6764] [serial = 169] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.918Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 21 (1cd62be4000) [pid = 6764] [serial = 161] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.919Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 20 (1cd5f484800) [pid = 6764] [serial = 191] [outer = 0] [url = about:restartrequired?e=restartrequired&u=about%3Ablank&c=UTF-8&d=%20]
[task 2024-09-02T17:14:46.919Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 19 (1cd619dbc00) [pid = 6764] [serial = 183] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.920Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 18 (1cd62be2c00) [pid = 6764] [serial = 155] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.921Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 17 (1cd62be7400) [pid = 6764] [serial = 165] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.927Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 16 (1cd595dd400) [pid = 6764] [serial = 193] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.927Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 15 (1cd61fbbc00) [pid = 6764] [serial = 176] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.928Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (1cd62be9c00) [pid = 6764] [serial = 195] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.928Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 13 (1cd62e0fc00) [pid = 6764] [serial = 163] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.933Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (1cd63264400) [pid = 6764] [serial = 185] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.933Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (1cd62e08400) [pid = 6764] [serial = 171] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:46.934Z] 17:14:46     INFO - GECKO(3260) | [Parent 6764: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (1cd6339f000) [pid = 6764] [serial = 178] [outer = 0] [url = about:blank]
[task 2024-09-02T17:14:51.279Z] 17:14:51     INFO - GECKO(3260) | [Child 7636: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (1f91b3d0000) [pid = 7636] [serial = 2] [outer = 0] [url = about:blank]
[task 2024-09-02T17:15:05.280Z] 17:15:05     INFO - GECKO(3260) | [Parent 6764, Jump List #2] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/widget/windows/WinUtils.cpp:968
[task 2024-09-02T17:15:05.281Z] 17:15:05     INFO - GECKO(3260) | console.warn: WindowsJumpLists: "Failed to fetch favicon for " "https://example.com/" ({})
[task 2024-09-02T17:15:05.282Z] 17:15:05     INFO - GECKO(3260) | console.warn: WindowsJumpLists: "Failed to fetch favicon for " "http://example.com/" ({})
[task 2024-09-02T17:15:05.283Z] 17:15:05     INFO - GECKO(3260) | console.warn: WindowsJumpLists: "Failed to fetch favicon for " "https://test1.example.com/" ({})
[task 2024-09-02T17:15:05.285Z] 17:15:05     INFO - GECKO(3260) | console.warn: WindowsJumpLists: "Failed to fetch favicon for " "http://mochi.test:8888/browser/browser/modules/test/browser/contain_iframe.html" ({})
[task 2024-09-02T17:15:05.285Z] 17:15:05     INFO - GECKO(3260) | console.warn: WindowsJumpLists: "Failed to fetch favicon for " "https://example.com/browser/browser/modules/test/browser/dummy_page.html" ({})
[task 2024-09-02T17:15:05.286Z] 17:15:05     INFO - GECKO(3260) | console.warn: WindowsJumpLists: "Failed to fetch favicon for " "http://example.net/" ({})
[task 2024-09-02T17:15:05.287Z] 17:15:05     INFO - GECKO(3260) | console.warn: WindowsJumpLists: "Failed to fetch favicon for " "http://example.org/" ({})
[task 2024-09-02T17:15:05.288Z] 17:15:05     INFO - GECKO(3260) | [Parent 6764, Jump List #2] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/widget/windows/WinUtils.cpp:968
[task 2024-09-02T17:16:11.059Z] 17:16:11     INFO - TEST-INFO | started process screenshot
[task 2024-09-02T17:16:11.206Z] 17:16:11     INFO - TEST-INFO | screenshot: exit 0
[task 2024-09-02T17:16:11.207Z] 17:16:11     INFO - Buffered messages logged at 17:14:38
[task 2024-09-02T17:16:11.208Z] 17:16:11     INFO - Entering test bound toolbarButtons
[task 2024-09-02T17:16:11.208Z] 17:16:11     INFO - Adding a bookmark to the bookmarks toolbar.
[task 2024-09-02T17:16:11.209Z] 17:16:11     INFO - Buffered messages logged at 17:14:39
[task 2024-09-02T17:16:11.210Z] 17:16:11     INFO - Global property added while loading chrome://browser/content/tabbrowser/browser-allTabsMenu.js: TabsPanel
[task 2024-09-02T17:16:11.210Z] 17:16:11     INFO - Buffered messages finished
[task 2024-09-02T17:16:11.211Z] 17:16:11     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_interaction.js | Test timed out - 
[task 2024-09-02T17:16:11.211Z] 17:16:11     INFO - GECKO(3260) | Completed ShutdownLeaks collections in process 6764
[task 2024-09-02T17:16:11.211Z] 17:16:11     INFO - TEST-START | Shutdown
Flags: needinfo?(mak)

Ah, I forgot to update the test as I changed "initialized" to a boolean attribute.

Flags: needinfo?(mak)
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/8ed8af424513 Bookmarks Toolbar empty message flickers with opening new windows. r=daisuke,desktop-theme-reviewers,places-reviewers,dao

Set release status flags based on info from the regressing bug 1818461

status-firefox132: --- → affected

https://hg.mozilla.org/mozilla-central/rev/8ed8af424513

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox132: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch

The patch landed in nightly and beta is affected.
:mak, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(mak)

I prefer to let it ride the train to Release normally, that's also why I awaited the merge.

status-firefox131: affected → wontfix
Flags: needinfo?(mak)

I was able to reproduce the issue on Win10x64 using Firefox build 129.0a1 (2024-06-14).
Verified as fixed on Win10x64 using Firefox build 134.0a1 and 133.0b9.

status-firefox132: fixed → verified
status-firefox133: --- → verified
status-firefox134: --- → verified
Flags: qe-verify+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: