1902429 - SelectTranslationsPanel top and bottom margins are too small

Status: RESOLVED INVALID

(Firefox :: Translations, defect)

Description

[Erik Nordin [:nordzilla]]

Description

Bug 1901314 removed the HTML element id select-translations-panel-a11y-document-wrapper which was actually being used for a cSS rule.

I didn't realize it during review, but we should add that id back in.

---

Steps to implement

• Reintroduce the id to the markup.

---

Tests to implement

• This is a visual-only change. No automated testing needed.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1902429 - Fix SelectTranslationsPanel top/bottom margins r=#translations-reviewers,ohall

Re-introduces an id that was removed by a different patch,
for which there was an active CSS rule for.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1902429 - Reduce SelectTranslationsPanel top/bottom margin r=#desktop-theme-reviewers!

Reduces the size of the top/bottom margin of the SelectTranslationsPanel.

Depends on D213677

Comment 3

[Erik Nordin [:nordzilla]]

After discussing with UX, Desktop Themes Reviewers, and Acorn team, we have decided to move forward with the current panel margins.