1901314 - Improve Select Translations panel announcements for screen readers

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Build on the bug 1894098 work and ensure:

1. When panel opens, it is announced as Translations Beta (while Beta is present, both via aria-labelledby) and additionally Manage translation settings is also announced (via aria-describedby).
   1. Note: VoiceOver may announce only the description. - this is likely a VO bug (will investigate), but programmatically in the Accessibility tree the label and descriptions should be as described (could be confirmed via Dev Tools > Accessibility Inspector with settings > "Disable Popup Auto-hide" option of dev tools being checked)
2. The <textarea> with translation output is labelled - and the label could be both the To/From languages, i.e. From English to French via aria-labelledby)

Comment 1

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Attachment: Bug 1901314 - Improve Select Translations panel labelling. r=nordzilla!

Ensure the Select Translations panel's label is including "Beta" marker (while it is present), that the description includes the Manage Settings button, and that the <textarea> is labeled.

Comment 2

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Attachment: Screenshot of the Select Translations panel announcement by NVDA with the Accessibility Inspector output

With the patch provided above, the announcement with NVDA is the following on panel init:

alert  Translation complete
dialog
Translation Beta  document  Manage translation settings
From Russian To English  edit  read only  multi line  Translating…

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e966f6171ac
Improve Select Translations panel labelling. r=nordzilla,translations-reviewers

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9e966f6171ac

Comment 5

[Daniel Bodea [:danibodea]]

NVDA behavior before the fix: "alert translation complete. dialog. translation document. edit read only multiline translating."
NVDA behavior after the fix: "dialog. translation beta docu... (interruption) alert translation complete. translation beta document, manage translation settings. from <origin language> to <destination language> edit read only multiline translating."

VoiceOver behavior before the fix: "<attempts to read the origin text> insertion at beginning of text, translating... (interruption) you are currently on a text area inside a document. to exit... firefox nightly has new window."; if the user navigates outwards (VO+SHIFT+UP) VoiceOver: "Out of Translation"
VoiceOver behavior after the fix: "<attempts to read the origin text> from <origin language> to <destination language> insertion at beginning of text. firefox nightly has new window. you are currently..."; if the user navigates outwards (VO+SHIFT+UP) VoiceOver: "Out of Translation Beta"

ORCA behavior before the fix: "read only entry translating; focus mode. alert, translation complete."
ORCA behavior after the fix: "from <origin language> to <destination language> read only entry translating. focus mode. alert, translation complete."

I can confirm that the screen reader announcements are slightly improved, as intended;

1. NVDA and VoiceOver mention the label "beta" along with the accessible name "Translation".
2. NVDA, ORCA and VoiceOver announce the origin language and destination language set in the panel.

Closing report as verified in Nightly v129.0a1 from 2024-06-11 in Windows10, MacOS11 and Ubuntu22.
I think this fix should be uplifted to Beta128. What do you think?

Comment 6

[Erik Nordin [:nordzilla]]

I've got this patch included in my beta uplift stack.

8: 2024-06-14 - No bug - Tagging 911224e0276b9760e454a3663bf7b36e87f0c145 with FIREFOX-ANDROID_128_0b3_BUILD1 a=release CLOSED TREE DONTBUILD
7: 2024-06-10 - Bug 1894542 - Increase contrast of textarea resizer r=#desktop-theme-reviewers!,dao
6: 2024-06-14 - Bug 1901888 - Ensure textarea border has sufficient color contrast r=#desktop-theme-reviewers!
5: 2024-06-10 - Bug 1901314 - Improve Select Translations panel labelling. r=nordzilla!
4: 2024-06-13 - Bug 1902254 - Increase SelectTranslationsPanel resize buffer r=#translations-reviewers!,ohall
3: 2024-06-13 - Bug 1900023 - Fix SelectTranslationsPanel keyboard navigation on macOS r=#translations-reviewers!,ohall
2: 2024-06-14 - Bug 1902583 - Split up try-again-button keypress test r=#translations-reviewers!,ohall
1: 2024-06-11 - Bug 1901351 - Do not offer Translate Link Text for URLs r=#translations-reviewers!,ohall

I will be requesting uplift as soon as all the patches successfully land in tree.

The final patch in that list was queued for landing about 20 minutes ago.

Comment 7

[Erik Nordin [:nordzilla]]

Attachment: Bug 1901314 - Improve Select Translations panel labelling.

Ensure the Select Translations panel's label is including "Beta" marker (while it is present), that the description includes the Manage Settings button, and that the <textarea> is labeled.

Original Revision: https://phabricator.services.mozilla.com/D212966

Comment 8

[Erik Nordin [:nordzilla]]

Attachment: Bug 1901314 - Improve Select Translations panel labelling.

Ensure the Select Translations panel's label is including "Beta" marker (while it is present), that the description includes the Manage Settings button, and that the <textarea> is labeled.

Original Revision: https://phabricator.services.mozilla.com/D212966

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: This patch stack contains core quality-of-life functionality and defect fixes that will provide the best possible experience for Select Translations users on release.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: QA will already be verifying all of this in the beta test process for Select Translations
• Risk associated with taking this patch: Low Risk
• Explanation of risk level: These changes are all well tested in automation and will be verified by QA as part of the sign-off process for Select Translations
• String changes made/needed: None
• Is Android affected?: no

Comment 10

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Thank you very much for testing the results, Daniel! And thank you, Erik, for the Beta uplift request!

I think the main remaining questions are to the VoiceOver and ORCA because they do not announce the programmatic name of the panel. Also, the panel would now (with this patch) include a description which should mention the Settings control too (it was doing it with NVDA when I tested it last week). The label announcements are now tracked in the separate by OS bug 1902662 and bug 1902665, since they may be caused by platform and/or screen readers themselves.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/32423afeb68e

Comment 12

[Daniel Bodea [:danibodea]]

I can confirm that the improvements observed in Nightly v129.0a1 are also present in Beta v128.0b5.
The screen reader announcements are slightly improved:

• NVDA and VoiceOver mention the label "beta" along with the accessible name "Translation".
• NVDA, ORCA and VoiceOver announce the origin language and destination language set in the panel.