1902603 - Enable tests for bug 1806161 - Thunderbird doesn't decrypt S/MIME encrypted message wrapped in a digital signature

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[Magnus Melin [:mkmelin]]

We have tests that say they should be enabled after bug 1806161 lands.
https://searchfox.org/comm-central/rev/40f0b5fe6b3a2f745e42b1a9d4d3f73d37d4e548/mail/test/browser/openpgp/browser_viewMessage.js#11-14

Unfortunately, the test does not work. The content does not get decrypted. I don't know why.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: WIP: Bug 1902603 - enable bug 1806161 s/mime tests.

Comment 2

[Kai Engert [:KaiE:]]

thanks for reminding me, I'll investigate

Comment 3

[Kai Engert [:KaiE:]]

I found the simple explanation:

When we refresh the S/MIME test data and keys, new secret keys were created.

The files we had added here had been manually crafted before that date,
we didn't update these test messages,
and therefore we don't have the matching keys to decrypt them.

Comment 4

[Kai Engert [:KaiE:]]

I'll create updated test messages.

Comment 5

[Kai Engert [:KaiE:]]

I see for S/MIME messages we also need different logic for accessing the decrypted contents, which lives in test_smime_decrypt.js

I'll move the test and the files over to the S/MIME area.

Comment 6

[Magnus Melin [:mkmelin]]

That explains the failure, but it's unfortunate that the result of such an error case is just a blank message pane, with no explanation or banner. Normally if one doesn't have the secret key there's a notification about that.

Comment 7

[Kai Engert [:KaiE:]]

Attachment: Bug 1902603 - Enable prepared test files for Outer-S/MIME-sig-with-inner-S/MIME-encryption. r=mkmelin

Comment 8

[Kai Engert [:KaiE:]]

(In reply to Magnus Melin [:mkmelin] from comment #6)

That explains the failure, but it's unfortunate that the result of such an error case is just a blank message pane, with no explanation or banner. Normally if one doesn't have the secret key there's a notification about that.

I agree we should fix that.
I'll handle that in a separate patch.

Comment 9

[Kai Engert [:KaiE:]]

(In reply to Magnus Melin [:mkmelin] from comment #6)

That explains the failure, but it's unfortunate that the result of such an error case is just a blank message pane, with no explanation or banner. Normally if one doesn't have the secret key there's a notification about that.

I can reproduce the "not error message" if I open the message from file.

I do get the error message if the file is inside a folder.

The cause is bug 1902991. We currently always skip processing of status for S/MIME emails opened from file, and as a result, we don't reach the code that displays the error.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/90483a87d419
Enable prepared test files for Outer-S/MIME-sig-with-inner-S/MIME-encryption. r=mkmelin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/45640a98a9a3
Follow-up to fix lint. rs=me DONTBUILD