S/MIME status (encryption/signature) not shown when opening message from file
Categories
(MailNews Core :: Security: S/MIME, defect)
Tracking
(thunderbird_esr115 affected, thunderbird_esr128 affected, thunderbird128 fixed)
People
(Reporter: KaiE, Assigned: KaiE)
References
Details
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
corey
:
approval-comm-beta+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Save an S/MIME message to a file.
Use Thunderbird, File, Open, Saved Message, and select it.
The status header section doesn't show any S/MIME status indicators.
The reason is the check in msgHdrViewSMIMEOverlay.js, in both signedStatus() and encryptionStatus().
if (aMsgNeckoURL != this.getSelectedMessageURI()) {
// Status isn't for selected message.
return;
}
There is no selected message when we're opening from file.
I suggest we reuse the check from the OpenPGP code, which covers this scenario.
I have a working patch already, but I want to adjust it to avoid code duplication.
Assignee | ||
Comment 1•12 days ago
|
||
The fix changes the result of existing test testOuterSmimeSigInnerPgpEncryptedInsideMixed.
Because in that message the outer signature isn't ignored, it's expected that an S/MIME signature status indicator is shown.
The test currently checks that the signature status icon is hidden. The fact that it was hidden was a result of this bug.
I'll fix that test.
Assignee | ||
Comment 2•12 days ago
|
||
Updated•12 days ago
|
Assignee | ||
Updated•12 days ago
|
Assignee | ||
Updated•12 days ago
|
Assignee | ||
Updated•10 days ago
|
Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/8942c8f6ef35
S/MIME status must be shown when opening a message from file. r=mkmelin
Assignee | ||
Comment 4•10 days ago
|
||
Assignee | ||
Comment 5•10 days ago
|
||
Patch required backport/adjustments.
Assignee | ||
Comment 6•10 days ago
|
||
Assignee | ||
Comment 7•9 days ago
|
||
another revision submitted, and try build passed:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=7fa03540940955b2af4b7fbba48bb61c165281f3
(I had missed the test fix backport)
Assignee | ||
Comment 8•9 days ago
|
||
Comment on attachment 9407844 [details]
Bug 1902991 - S/MIME status must be shown when opening a message from file. r=mkmelin
[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: messages opened from file not showing s/mime status
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): rather low, small fix plus minimal refactoring
Updated•9 days ago
|
Comment 9•9 days ago
|
||
Comment on attachment 9407844 [details]
Bug 1902991 - S/MIME status must be shown when opening a message from file. r=mkmelin
[Triage Comment]
Approved for beta
Comment 10•9 days ago
|
||
bugherder uplift |
Thunderbird 128.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/b229b3fdf417
Description
•