1902991 - S/MIME status (encryption/signature) not shown when opening message from file

Status: VERIFIED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[Kai Engert [:KaiE:]]

Save an S/MIME message to a file.
Use Thunderbird, File, Open, Saved Message, and select it.

The status header section doesn't show any S/MIME status indicators.

The reason is the check in msgHdrViewSMIMEOverlay.js, in both signedStatus() and encryptionStatus().

if (aMsgNeckoURL != this.getSelectedMessageURI()) {
  // Status isn't for selected message.
  return;
}

There is no selected message when we're opening from file.

I suggest we reuse the check from the OpenPGP code, which covers this scenario.

I have a working patch already, but I want to adjust it to avoid code duplication.

Comment 1

[Kai Engert [:KaiE:]]

The fix changes the result of existing test testOuterSmimeSigInnerPgpEncryptedInsideMixed.

Because in that message the outer signature isn't ignored, it's expected that an S/MIME signature status indicator is shown.

The test currently checks that the signature status icon is hidden. The fact that it was hidden was a result of this bug.
I'll fix that test.

Comment 2

[Kai Engert [:KaiE:]]

Attachment: Bug 1902991 - S/MIME status must be shown when opening a message from file. r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8942c8f6ef35
S/MIME status must be shown when opening a message from file. r=mkmelin

Comment 4

[Kai Engert [:KaiE:]]

Attachment: Bug 1902991 - S/MIME status must be shown when opening a message from file, backport to esr115. r=mkmelin

Comment 5

[Kai Engert [:KaiE:]]

Patch required backport/adjustments.

Comment 6

[Kai Engert [:KaiE:]]

esr115 try run here:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=00df9df45445355002c29ca20a61485b8211198e

Comment 7

[Kai Engert [:KaiE:]]

another revision submitted, and try build passed:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=7fa03540940955b2af4b7fbba48bb61c165281f3

(I had missed the test fix backport)

Comment 8

[Kai Engert [:KaiE:]]

Comment on attachment 9407844 [details]
Bug 1902991 - S/MIME status must be shown when opening a message from file. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: messages opened from file not showing s/mime status
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): rather low, small fix plus minimal refactoring

Comment 9

[Corey Bryant]

Comment on attachment 9407844 [details]
Bug 1902991 - S/MIME status must be shown when opening a message from file. r=mkmelin

[Triage Comment]
Approved for beta

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 128.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/b229b3fdf417

Comment 11

[Kai Engert [:KaiE:]]

Comment on attachment 9408523 [details] [diff] [review]
Bug 1902991 - S/MIME status must be shown when opening a message from file, backport to esr115. r=mkmelin

[Approval Request Comment]
see comment 8

Comment 12

[Kai Engert [:KaiE:]]

backporting to 115 would be just nice to have, if we'll support it for another while.

Comment 13

[Corey Bryant]

Comment on attachment 9408523 [details] [diff] [review]
Bug 1902991 - S/MIME status must be shown when opening a message from file, backport to esr115. r=mkmelin

[Triage Comment]
Approved for esr115

Comment 14

[Corey Bryant]

Thunderbird 115.16.3esr:
https://hg.mozilla.org/releases/comm-esr115/rev/c2717f208fdd

Comment 15

[Ramona Gavrilescu]

Confirming this issue as verified fixed on 115.16.3(20241118222652) using Mac 14.7

Comment 16

[Kai Engert [:KaiE:]]

Attachment: Bug 1902991 - S/MIME status must be shown when opening a message from file, backport to esr115. r=mkmelin