1902684 - Allow MOZ_APP_VENDOR to be an empty string

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Rob Lemley [:rjl]]

Bug 1898177 forces MOZ_APP_VENDOR to have be non-zero length string. This breaks Thunderbird which has historically never set it.

xpcshellConstants.js states that MOZ_APP_VENDOR is optional, and nsXREDirProvider allows for it as well.

Unless the spec is changing, an empty string should be allowed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sergesanspaille, since you are the author of the regressor, bug 1898177, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[[:sergesanspaille]]

As discussed on #build, the right path would be to set imply_option("MOZ_APP_VENDOR", "") while allowing for empty MOZ_APP_VENDOR (compared to it being unset)

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1902684 - Allow an empty string for MOZ_APP_VENDOR. r=glandium

Thunderbird has historically not set MOZ_APP_VENDOR. An empty
string evaluates falsy, so simply allow it.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1898177

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Rob, is this still in progress or waiting for review? Thanks!

Comment 6

[Rob Lemley [:rjl]]

This can be closed. In the end, setting MOZ_APP_VENDOR=Mozilla should have been done ages ago. It affects the location of the profile directory though, unless MOZ_APP_PROFILE is set, which Thunderbird is now doing.

There's a few places where old assumptions of an empty vendor string need updating and they are being worked through in comm-central.