1902688 - Port bug 1898177: Deal with MOZ_APP_VENDOR now being required

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Rob Lemley [:rjl]]

Bug 1898177 made MOZ_APP_VENDOR required. It cannot be an empty string.

To avoid profile problems, Thunderbird can set MOZ_APP_PROFILE to "thunderbird".

Other problems will come up.

• default browser agent (N/A)
• dllprefetchexperiment (???)
• Symbols dumper/uploader (probably not a big deal?)
• Background tasks (unused?)
• Windows Launcher Registry keys -- This could be a problem!!
• Windows TaskbarID registry keys -- Also a problem

Ideally bug 1902684 will be accepted and this bug can be backed out.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1902688 - Port bug 1898177: Set MOZ_APP_VENDOR to Mozilla. r=#thunderbird-build-system-reviewers

Also set MOZ_APP_PROFILE to "thunderbird" to avoid problems with it
moving.
Other issues will come up. See the notes in the bug. This patch will
hopefully be backed out.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cf2dcd35f049
Port bug 1898177: Set MOZ_APP_VENDOR to Mozilla. r=dandarnell

Comment 3

[Rob Lemley [:rjl]]

Bug 1902684 is in the autoland Lando queue, so comment 2 patch can be backed out and replaced.

Comment 4

[Rob Lemley [:rjl]]

Closing due to bug 1902684 being a closed as WONTFIX.