1902801 - Crash in [@ cubeb_coreaudio::backend::device_property::get_device_streams]

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[BugBot [:suhaib / :marco/ :calixte]]

Crash report: https://crash-stats.mozilla.org/report/index/7f8fae61-15b1-4dfa-9252-8ade80240610

MOZ_CRASH Reason: assertion `left != right` failed left: 0 right: 0

Top 10 frames of crashing thread:

0  XUL  MOZ_Crash  mfbt/Assertions.h:317
0  XUL  RustMozCrash  mozglue/static/rust/wrappers.cpp:18
1  XUL  mozglue_static::panic_hook  mozglue/static/rust/lib.rs:98
2  XUL  core::ops::function::Fn::call  library/core/src/ops/function.rs:79
3  XUL  <alloc::boxed::Box<F, A> as core::ops::function::Fn<Args>>::call  library/alloc/src/boxed.rs:2034
3  XUL  std::panicking::rust_panic_with_hook  library/std/src/panicking.rs:783
4  XUL  std::panicking::begin_panic_handler::{{closure}}  library/std/src/panicking.rs:657
5  XUL  std::sys_common::backtrace::__rust_end_short_backtrace  library/std/src/sys_common/backtrace.rs:171
6  XUL  rust_begin_unwind  library/std/src/panicking.rs:645
7  XUL  core::panicking::panic_fmt  library/core/src/panicking.rs:72

By querying Nightly crashes reported within the last 2 months, here are some insights about the signature:

• First crash report: 2024-06-10
• Process type: Parent
• Is startup crash: No
• Has user comments: No
• Is null crash: Yes - all crashes happened on null or near null memory address

By analyzing the backtrace, the regression may have been introduced by a patch [1] to fix Bug 1890186.

[1] https://hg.mozilla.org/mozilla-central/rev?node=ad954710c53f

:pehrsons, since you are the author of the potential regressor, could you please take a look?

Comment 1

[Andreas Pehrson [:pehrsons]]

[Tracking Requested - why for this release]: Looks like a bad assumption that aggregate devices cannot have an unknown sub device. Unclear when this can happen but it brings down the main process if it does.

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1902801 - Update cubeb-coreaudio-rs to f8a4ec05e5. r?#cubeb-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/073990df3224
Update cubeb-coreaudio-rs to f8a4ec05e5. r=cubeb-reviewers,padenot

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/073990df3224

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1902801 - Update cubeb-coreaudio-rs to f8a4ec05e5. r?#cubeb-reviewers

Original Revision: https://phabricator.services.mozilla.com/D213930

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Main process may crash when enumerating input devices. Exact condition unclear.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Very low
• Explanation of risk level: This is just a guard preventing a call from happening with a certain, invalid, value.
• String changes made/needed: None
• Is Android affected?: no

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ef16c80607ba