1903022 - Add Variant to the prefix list and VariantImplementation to the irrelevant list

Status: RESOLVED FIXED

(Socorro :: Signature, task, P3)

Description

[Andrew McCreight [:mccr8]]

Bug 1902941 kind of looks like a Nightly regression, but it was hard to tell because there was an existing bug on file. Variant is a very generic class used in many places, so we need to look past it to find an interesting frame. I think it is worth keeping it in the signature, because a lot of the crashes are release asserts in actual Variant code. It looks like there are usually only a few frames of Variant code so that shouldn't get too out of hand. Looking at crashes, I also see a number of frames of VariantImplementation, but I think that's not interesting, so I'll add it to the irrelevant signature list.

Example crash: bp-658f2fc6-159f-49d1-a70e-bf9d80240616

The current signature is:
[@ mozilla::Variant<T>::as ]
I think with my changes it'll turn into:
[@ mozilla::Variant<T>::as | mozilla::dom::quota::DirectoryLockImpl::Overlaps ]

Comment 1

[Andrew McCreight [:mccr8]]

https://github.com/mozilla-services/socorro/pull/6639

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: [mozilla-services/socorro] Bug 1903022 - Add Variant to the prefix list and VariantImplementation to the irrelevant list. (#6639)

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR [mozilla-services/socorro]: Bug 1903022 - Add Variant to the prefix list and VariantImplementation to the irrelevant list. (#6639) in 286cf3d.

Comment 4

[Daniel Thorn [:relud]]

setting this to P3 to because it will be deployed as part of the next regular release

Comment 5

[Daniel Thorn [:relud]]

This was deployed in bug 1906174 just now.