1903392 - Send Source Language Changes to SelectTranslationsPanel Telemetry

Status: VERIFIED FIXED

(Firefox :: Translations, task, P3)

Description

[Erik Nordin [:nordzilla]]

Description

While our flow-id telemetry can technically tell when the source language was changed from the unsupported-language view based on tracing the events in the flow, it will add extra cost on the data side to do these calculations.

It would be much better to add extra keys to the translate_button event when a user has decidedly changed the incorrectly detected source language and requested a corrected translation.

---

Steps to implement

• Add a from_language extra key to the SelectTranslationsPanel translate_button event.
• Add a to_language extra key to the SelectTranslationsPanel translate_button event.
• Add a detected_language extra key to the SelectTranslationsPanel translate_button event.

---

Tests to implement

• Ensure that these events have coverage in SelectTranslationsPanel telemetry tests.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1903392 - Send source-language changes to telemetry r=#translations-reviewers!

Adds the ability for the SelectTranslationsPanel to send
telemetry events when the source language is changed and a
translation is requested from the unsupported-language view.

Depends on D214159

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee34bff6e97d
Send source-language changes to telemetry r=translations-reviewers,gregtatum

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1903392 - Send source-language changes to telemetry

Adds the ability for the SelectTranslationsPanel to send
telemetry events when the source language is changed and a
translation is requested from the unsupported-language view.

Original Revision: https://phabricator.services.mozilla.com/D214160

Comment 4

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/bab94a6e47f4

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ee34bff6e97d

Comment 6

[Daniel Bodea [:danibodea]]

I can confirm that the onTranslateButton event contains the from_language, to_language and detected_language extra keys.
Verified in Windows10, MacOS11 and Ubuntu22 on Nightly v129.0a1 and Beta v128.0b7.