1903430 - Speedup resource array processing in resource command

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Bug 1901643 introduce a new RDP event to ease sending arrays of resources without repeating the resourceType attribute.
This was useful to reduce the performance regression introduced by bug 1902229.
But now, the logic in the ResourceCommand, in the client side could be optimized for this scenario.

DAMP with this patch on top of bug 1902229.
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=b87eaeb43bd55bf059c51c81862255910a1acfbe&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=a8bffd7a52e48a7ec74d7d666064369dc29040c5&page=1&showOnlyConfident=1
3.5% improvement in tracer UI.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1903430 - [devtools] Speedup resource array processing in resource command.

Reusing the existing implementation of onResourceAvailable/Updated/Destroyed
was forcing to duplicate and instantiate useless data, which caused visible performance regression.

I'm forking them. Once Fx129 is the default release, we should then be able to simply drop
the onResourceAvailable/Updated/Destroyed methods. Until them, we should remind ourself to maintain the two
distinct codepath. Hopefully, we don't do many changes on this core codebase.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55b5737362fa
[devtools] Speedup resource array processing in resource command. r=devtools-reviewers,nchevobbe

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/55b5737362fa