1903794 - Remove test_addon_to_theme_update test

Status: RESOLVED FIXED

(WebExtensions :: General, task)

Description

[Rob Wu [:robwu]]

The test_addon_to_theme_update test in test_ext_permissions_migrate.js was added in bug 1628239 and tests what happens when an extension with permissions upgrades to a static extension. This scenario is not possible due to the fix for bug 1750565.

The original purpose of the test is to confirm that there is no error when a static theme is updated (bug 1628239). The unit test doesn't reflect a static theme update, but an unrealistic extension-to-theme update.

Later, the original bug resurfaced as bug 1643854, and I fixed that in bug, along with a new test (toolkit/mozapps/extensions/test/xpcshell/test_update_theme.js) that does really test the static theme -> static theme update scenario. With this new test, the original test was no longer necessary.

Moreover, even if I undo the fixes to bug 1643854 and bug 1628239, the test_ext_permissions_migrate.js doesn't fail (at most there are some logged error messages). Altogether, this means that the original test does not serve any purpose and should just be removed.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1903794 - Delete obsolete test_addon_to_theme_update

As mentioned in the bug, this test is testing a scenario that cannot be
encountered in practice (extension -> theme update), and the necessary
coverage for the relevant scenario (theme -> theme update) already
exists elsewhere.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a51c1d3eaf5f
Delete obsolete test_addon_to_theme_update r=willdurand

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a51c1d3eaf5f