Closed Bug 1903840 Opened 2 years ago Closed 2 years ago

moz-checkbox and moz-radio should always use Acorn input styling

Categories

(Toolkit :: UI Widgets, defect, P3)

defect

Tracking

()

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: mstriemer, Assigned: ldebeasi, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [recomp] [lang=css])

Attachments

(1 external file)

When using moz-checkbox and moz-radio in the customize sidebar panel it inherited the OS specific input styling. We'd like to use our Acorn Design System styling for our checkboxes and radios however

We can tell the platform code to use our design system styling by setting -moz-theme: non-native on the input

I believe this can only be visibly noticed on macOS but should be a good first bug regardless of platform, just hard to test =\

Update these CSS files:

https://searchfox.org/mozilla-central/rev/ab488b411ff15c2e11dbd4d6be0455bb64bc8fc1/toolkit/content/widgets/moz-checkbox/moz-checkbox.css#22
https://searchfox.org/mozilla-central/rev/ab488b411ff15c2e11dbd4d6be0455bb64bc8fc1/toolkit/content/widgets/moz-radio-group/moz-radio.css#14

to set:

-moz-theme: non-native

eg

input {
  -moz-theme: non-native
  font-size: inherit;
  /* the rest unchanged */
}
Mentor: mstriemer
Keywords: good-first-bug
Whiteboard: [recomp] → [recomp] [lang=css]

Hey there,

I'm interested in submitting a fix for this. However, I'm not able to reproduce the issue on my Mac. Do you have any steps to reproduce the issue or a screenshot? It's possible I am not reproducing the issue correctly.

Hi Liam! Thanks for your interest here!

You can see the OS styled inputs in the settings for the new sidebar feature that is under development currently. Here's some STR to see it:

  1. Flip the sidebar.revamp pref to true
  2. Restart the browser
  3. Click the Settings/gear icon at the bottom of the new sidebar that is now shown
Assignee: nobody → ldebeasi
Status: NEW → ASSIGNED
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b246b83e381 Sidebar checkbox and radio use Acorn styling r=reusable-components-reviewers,tgiles
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: