1906642 - Firefox Tools Checkboxes from the Customize Sidebar panel do not change their state on Hover with High Contrast mode enabled

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: HighContrastCustomize.mp4

Found in

• Nightly 129.0a1

Affected versions

• Nightly 129.0a1 (2024-07-08)

Affected platforms

• Windows

Preconditions

• Set the following prefs:
  sidebar.revamp - true
  sidebar.verticalTabs - true
  Enable High Contrast mode.

Steps to reproduce

1. Open the Customize Sidebar panel.
2. Check All Firefox Tools Sidebar
3. Hover over each Checkbox.

Expected result

• The Firefox tools Checkboxes should change their state to blue when hovered over with High Contrast enabled.

Actual result

• The Firefox Tools checkboxes from the Customize Sidebar panel remain white with grey on hover with High Contrast enabled.

Regression range
Not a regression.

Comment 1

[Anna Yeddi [:ayeddi]]

The lack of the semantic styling in the High Contrast Mode (HCM) is an access-S3 issue since it makes it difficult to discern which element is, in fact, an active UI and could be activated if clicked, which one is now hovered and which one is not, for HCM users (those with low vision, users with cognitive disabilities, users with dyslexia, with colorblindness, and others).

We need to ensure the appropriate color pairs are used for forced-colors media query (HCM on Win): ButtonFacewithButtonTextfor the border/label text and for the control background. The hovered state is expected to useSelectedTextandSelectedBackground` color combination in place of the Button colors of the default state.

Adding a Figma reference for color combinations for different Win10 and Win11 themes (SSO required), as well as the checkboxes on HCM (SSO req'ed) and the radio buttons on HCM (SSO required).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the accessibility severity is higher, .
:sclements, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Stuart Colville [:muffinresearch]]

This is another bug that looks to be fixed by -moz-theme: non-native on the checkbox as per bug 1903840 which has a patch in review. Even if the fix happens at a lower level, when bug 1903840 is fixed that should solve the issues outlined in this bug.

Comment 4

[Stuart Colville [:muffinresearch]]

This was fixed via the patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1903840 (Note, this isn't yet in Nightly).

Comment 5

[Rares Doghi, Desktop QA]

Hi, I tried to verify the fix using the build 20240802091953 from Bug 1903840 but on a Windows 10 machine with High Contrast enabled the Checkboxes are still not changing their state to blue like in about:Preferences, I will add a screen recording of it.

Comment 6

[Rares Doghi, Desktop QA]

Attachment: 2024-08-02_17h11_02.mp4