Closed Bug 1903954 Opened 3 months ago Closed 3 months ago

Remove pref check for broadcasting close tab keys

Categories

(Firefox :: Sync, task)

Product:
Firefox
Component:
Sync
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: skhamis, Assigned: skhamis)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1903954: Remove pref check for broadcasting close tab keys r?lina,markh
48 bytes, text/x-phabricator-request
Details | Review

The team decided that we should have the broadcasting of the ability to close tabs available and use the pref to hide the actual sending. This will reduce set-up for people testing the feature and is relatively safe as this will be a new broadcasting feature so no current clients should be sending commands (yet)

Assignee: nobody → skhamis
Status: NEW → ASSIGNED
Pushed by skhamis@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3da5d373616a Remove pref check for broadcasting close tab keys r=markh

Backed out for causing xpcshell failures on test_accounts_device_registration.js.

[task 2024-06-21T23:29:20.717Z] 23:29:20     INFO -  TEST-START | services/fxaccounts/tests/xpcshell/test_accounts_device_registration.js
[task 2024-06-21T23:29:21.782Z] 23:29:21  WARNING -  TEST-UNEXPECTED-FAIL | services/fxaccounts/tests/xpcshell/test_accounts_device_registration.js | xpcshell return code: 0
[task 2024-06-21T23:29:21.782Z] 23:29:21     INFO -  TEST-INFO took 1063ms
[task 2024-06-21T23:29:21.783Z] 23:29:21     INFO -  >>>>>>>
[task 2024-06-21T23:29:21.783Z] 23:29:21     INFO -  PID 5376 | [Parent 5376, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2888
[task 2024-06-21T23:29:21.783Z] 23:29:21     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-06-21T23:29:21.784Z] 23:29:21     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-06-21T23:29:21.784Z] 23:29:21     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-06-21T23:29:21.785Z] 23:29:21     INFO -  running event loop
[task 2024-06-21T23:29:21.786Z] 23:29:21     INFO -  services/fxaccounts/tests/xpcshell/test_accounts_device_registration.js | Starting test_updateDeviceRegistration_with_new_device
[task 2024-06-21T23:29:21.786Z] 23:29:21     INFO -  (xpcshell/head.js) | test test_updateDeviceRegistration_with_new_device pending (2)
[task 2024-06-21T23:29:21.787Z] 23:29:21     INFO -  PID 5376 | 1719012561018	FirefoxAccounts	DEBUG	FxAccountsPush loading service
[task 2024-06-21T23:29:21.790Z] 23:29:21     INFO -  PID 5376 | 1719012561021	FirefoxAccounts	TRACE	initializing new storage manager
[task 2024-06-21T23:29:21.793Z] 23:29:21     INFO -  PID 5376 | 1719012561022	FirefoxAccounts	TRACE	starting fetch of json user data
[task 2024-06-21T23:29:21.796Z] 23:29:21     INFO -  PID 5376 | 1719012561025	FirefoxAccounts	DEBUG	FxAccountsPush initialized
[task 2024-06-21T23:29:21.803Z] 23:29:21     INFO -  PID 5376 | 1719012561030	FirefoxAccounts	TRACE	CloseRemoteTab observer created
[task 2024-06-21T23:29:21.803Z] 23:29:21     INFO -  PID 5376 | 1719012561031	FirefoxAccounts	DEBUG	setSignedInUser - aborting any existing flows
[task 2024-06-21T23:29:21.803Z] 23:29:21     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2024-06-21T23:29:21.803Z] 23:29:21     INFO -  PID 5376 | 1719012561032	FirefoxAccounts	DEBUG	startVerifiedCheck: false
[task 2024-06-21T23:29:21.803Z] 23:29:21     INFO -  PID 5376 | 1719012561033	FirefoxAccounts	DEBUG	whenVerified promise starts polling for verified email
[task 2024-06-21T23:29:21.803Z] 23:29:21     INFO -  PID 5376 | 1719012561033	FirefoxAccounts	DEBUG	entering startPollEmailStatus: start
[task 2024-06-21T23:29:21.803Z] 23:29:21     INFO -  PID 5376 | 1719012561033	FirefoxAccounts	DEBUG	entering pollEmailStatus: start
[task 2024-06-21T23:29:21.804Z] 23:29:21     INFO -  PID 5376 | 1719012561076	Sync.Status	INFO	Resetting Status.
[task 2024-06-21T23:29:21.804Z] 23:29:21     INFO -  PID 5376 | 1719012561076	Sync.Status	DEBUG	Status.service: undefined => success.status_ok
[task 2024-06-21T23:29:21.804Z] 23:29:21     INFO -  PID 5376 | 1719012561078	Sync.SyncScheduler	TRACE	Setting SyncScheduler policy values to defaults.
[task 2024-06-21T23:29:21.804Z] 23:29:21     INFO -  PID 5376 | 1719012561078	Sync.SyncScheduler	DEBUG	Clearing sync triggers and the global score.
[task 2024-06-21T23:29:21.804Z] 23:29:21     INFO -  PID 5376 | 1719012561079	Sync.Status	DEBUG	Status.login: success.login => error.login.reason.no_username
[task 2024-06-21T23:29:21.804Z] 23:29:21     INFO -  PID 5376 | 1719012561079	Sync.Status	DEBUG	Status.service: success.status_ok => service.client_not_configured
[task 2024-06-21T23:29:21.804Z] 23:29:21     INFO -  PID 5376 | 1719012561079	Sync.Status	DEBUG	Status.service: service.client_not_configured => service.client_not_configured
[task 2024-06-21T23:29:21.804Z] 23:29:21     INFO -  PID 5376 | 1719012561083	Sync.Service	INFO	Loading Weave 1.131.0
[task 2024-06-21T23:29:21.804Z] 23:29:21     INFO -  PID 5376 | 1719012561085	Sync.Engine.Clients	DEBUG	Engine constructed
<...>
[task 2024-06-21T23:29:22.074Z] 23:29:22     INFO -  PID 5376 | 1719012561564	FirefoxAccounts	DEBUG	registering new device details
[task 2024-06-21T23:29:22.074Z] 23:29:22     INFO -  TEST-PASS | services/fxaccounts/tests/xpcshell/test_accounts_device_registration.js | test_verification_updates_registration - [test_verification_updates_registration : 644] 0 == 0
[task 2024-06-21T23:29:22.074Z] 23:29:22     INFO -  PID 5376 | 1719012561566	FirefoxAccounts	DEBUG	entering pollEmailStatus: start
[task 2024-06-21T23:29:22.074Z] 23:29:22     INFO -  PID 5376 | 1719012561567	FirefoxAccounts	DEBUG	checkEmailStatus -> {"email":"baz@example.com","uid":"1ad7f502-4cc7-4ec1-a209-071fd2fae348","sessionToken":"baz's session token","verified":true,"scopedKeys":{"https://identity.mozilla.com/apps/oldsync":{"kid":"1234567890123-u7u7u7u7u7u7u7u7u7u7uw","k":"qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqg","kty":"oct"}}}
[task 2024-06-21T23:29:22.074Z] 23:29:22     INFO -  PID 5376 | 1719012561567	FirefoxAccounts	INFO	the user became verified
[task 2024-06-21T23:29:22.074Z] 23:29:22     INFO -  PID 5376 | 1719012561568	FirefoxAccounts	DEBUG	Notifying observers of fxaccounts:onverified
[task 2024-06-21T23:29:22.075Z] 23:29:22     INFO -  PID 5376 | 1719012561570	Sync.SyncAuthManager	DEBUG	observed fxaccounts:onverified
[task 2024-06-21T23:29:22.075Z] 23:29:22     INFO -  PID 5376 | 1719012561570	Sync.SyncAuthManager	INFO	Sync is not configured, so ignoring the notification
[task 2024-06-21T23:29:22.075Z] 23:29:22     INFO -  PID 5376 | 1719012561571	FirefoxAccounts	INFO	Generating and persisting encrypted sendtab keys
[task 2024-06-21T23:29:22.075Z] 23:29:22     INFO -  PID 5376 | 1719012561573	Sync.BulkKeyBundle	INFO	BulkKeyBundle being created for undefined
[task 2024-06-21T23:29:22.075Z] 23:29:22     INFO -  PID 5376 | 1719012561575	FirefoxAccounts	INFO	Generating and persisting encrypted closeTab keys
[task 2024-06-21T23:29:22.076Z] 23:29:22     INFO -  PID 5376 | 1719012561576	Sync.BulkKeyBundle	INFO	BulkKeyBundle being created for undefined
[task 2024-06-21T23:29:22.076Z] 23:29:22     INFO -  PID 5376 | 1719012561579	FirefoxAccounts	INFO	registering with available commands: ["https://identity.mozilla.com/cmd/close-uri/v1","https://identity.mozilla.com/cmd/open-uri"]
[task 2024-06-21T23:29:22.076Z] 23:29:22     INFO -  PID 5376 | 1719012561579	FirefoxAccounts	DEBUG	updating existing device details
[task 2024-06-21T23:29:22.076Z] 23:29:22  WARNING -  TEST-UNEXPECTED-FAIL | services/fxaccounts/tests/xpcshell/test_accounts_device_registration.js | test_verification_updates_registration - [test_verification_updates_registration : 668] 2 == 1
[task 2024-06-21T23:29:22.077Z] 23:29:22     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_accounts_device_registration.js:test_verification_updates_registration:668
[task 2024-06-21T23:29:22.077Z] 23:29:22     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:245
[task 2024-06-21T23:29:22.077Z] 23:29:22     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:596
[task 2024-06-21T23:29:22.077Z] 23:29:22     INFO -  -e:null:1
[task 2024-06-21T23:29:22.077Z] 23:29:22     INFO -  exiting test
[task 2024-06-21T23:29:22.077Z] 23:29:22     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2024-06-21T23:29:22.077Z] 23:29:22     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:869:20
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:981:5
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:70:21
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:251:10
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  equal@resource://testing-common/Assert.sys.mjs:293:8
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  test_verification_updates_registration@/builds/worker/workspace/build/tests/xpcshell/tests/services/fxaccounts/tests/xpcshell/test_accounts_device_registration.js:668:12
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:245:6
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:596:5
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  @-e:1:1
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  exiting test
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  PID 5376 | 1719012561584	Sync.SyncScheduler	DEBUG	Clearing sync triggers and the global score.
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  PID 5376 | (xpcshell:5376): GLib-GObject-WARNING **: 23:29:21.769: invalid (NULL) pointer instance
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  PID 5376 | (xpcshell:5376): GLib-GObject-CRITICAL **: 23:29:21.769: g_signal_handlers_disconnect_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
[task 2024-06-21T23:29:22.078Z] 23:29:22     INFO -  PID 5376 | [Parent 5376, Main Thread] WARNING: OOPDeinit() without successful OOPInit(): file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:3460
[task 2024-06-21T23:29:22.079Z] 23:29:22     INFO -  PID 5376 | [Parent 5376, Main Thread] WARNING: XPCOM object PerThreadData destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:216
[task 2024-06-21T23:29:22.079Z] 23:29:22     INFO -  PID 5376 | [Parent 5376, Main Thread] WARNING: XPCOM object SourceList destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:216
[task 2024-06-21T23:29:22.079Z] 23:29:22     INFO -  <<<<<<<
[task 2024-06-21T23:29:22.079Z] 23:29:22     INFO -  INFO | Result summary:
[task 2024-06-21T23:29:22.079Z] 23:29:22     INFO -  INFO | Passed: 19
[task 2024-06-21T23:29:22.079Z] 23:29:22  WARNING -  INFO | Failed: 1
[task 2024-06-21T23:29:22.080Z] 23:29:22  WARNING -  One or more unittests failed.
[task 2024-06-21T23:29:22.080Z] 23:29:22     INFO -  INFO | Todo: 0
[task 2024-06-21T23:29:22.080Z] 23:29:22     INFO -  INFO | Retried: 1
[task 2024-06-21T23:29:22.080Z] 23:29:22     INFO -  SUITE-END | took 12s
[task 2024-06-21T23:29:22.080Z] 23:29:22     INFO -  Node moz-http2 server shutting down ...
[task 2024-06-21T23:29:22.080Z] 23:29:22     INFO -  http3Server server shutting down ...
[task 2024-06-21T23:29:22.081Z] 23:29:22     INFO - Return code: 1
[task 2024-06-21T23:29:22.082Z] 23:29:22     INFO - TinderboxPrint: xpcshell-xpcshell<br/>19/<em class="testfail">1</em>/0
[task 2024-06-21T23:29:22.082Z] 23:29:22  WARNING - setting return code to 2
[task 2024-06-21T23:29:22.082Z] 23:29:22     INFO - The xpcshell suite: xpcshell ran with return status: FAILURE
Flags: needinfo?(skhamis)
Pushed by skhamis@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1ee482a2c462 Remove pref check for broadcasting close tab keys r=markh

https://hg.mozilla.org/mozilla-central/rev/1ee482a2c462

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
Flags: needinfo?(skhamis)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: