1903974 - spurious additional gaps in content-exposed buffered ranges after samples are removed

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Karl Tomlinson (:karlt)]

Bug 1878510 comment 79 saw lots of small gaps showing up in the buffered range after RemoveFrames recalculates the whole buffered range using the maximum removed frame duration for fuzz.
Sometimes the removed duration was zero and so there was no fuzz at all.
maxSampleDuration was intended to apply only as fuzz to removed frames.
This is different from insertion which uses the longest frame duration since the key frame.

Comment 1

[Karl Tomlinson (:karlt)]

RemoveFrames() can instead reduce mSanitizedBufferedRanges by the change in mBufferedRanges:
https://treeherder.mozilla.org/jobs?repo=try&revision=dc18cabced2e96254e3b52891f3ea1faa417ceeb

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1903974 On frame removal, subtract only new gaps from mSanitizedBufferedRanges r?#media-playback-reviewers

The previous recalculation of mSanitizedBufferedRanges with a different fuzz
would introduce additional spurious gaps in the buffered ranges if the
durations of the removed frames were small.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1220033

Comment 4

[Donal Meehan [:dmeehan]]

:karlt Fx128 is in the last week of beta, this is an older issue going by the regressor.
Do you plan on landing this soon?
Wondering if it should ride the train with Fx129 and then wonfix it for Fx128, or should it be considered for Fx128 uplift.
Asking since it has an S2 severity, what do you think?

Comment 5

[Karl Tomlinson (:karlt)]

I think we should wontfix for Fx128, thanks.

I expect that the effects of this bug are rare now that we have the fixes that landed for bug 1878510 and bug 1900191 (due to their removal of zero frame duration situations). We can drop the severity now for those reasons too.

There is some complexity in the code change here, and I don't know of a remaining urgent need to require uplift.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53b744845abd
On frame removal, subtract only new gaps from mSanitizedBufferedRanges r=media-playback-reviewers,alwu

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/53b744845abd