1904489 - Enable devtools.debugger.features.codemirror-next by default

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Let's enable CodeMirror 6 once everything look good

Comment 1

[Hubert Boma Manilla (:bomsy)]

Things to do here

• Switch the codemirror prefs here https://searchfox.org/mozilla-central/search?q=pref%28%22devtools.debugger.features.codemirror-next&path=&case=true&regexp=false
• Bump the tier for the cm6 variant from 3 to 2

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1904489 - [devtools] Enable Codemirror 6 by default r=#devtools-reviewers

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1904489 - [devtools] Fix keyboard naviagtion and outline tests r=#devtools-reviewers

Comment 4

[Phabricator Automation]

Comment on attachment 9429522 [details]
Bug 1904489 - [devtools] Fix keyboard naviagtion and outline tests r=#devtools-reviewers

Revision D224881 was moved to bug 1900395. Setting attachment 9429522 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9bde3aebf97
[devtools] Enable Codemirror 6 by default r=devtools-reviewers,nchevobbe

Comment 6

[Iulian Moraru]

Backed out 4 changesets (bug 1900395, bug 1904489, bug 1920928) for causing multiple dt failures.

• Push with failures

• Failure log for failures on browser_dbg-preview.js

• Failure log for failures on browser_dbg-blackbox.js

• [Failure log for failures on browser_target_command_service_workers_navigation.js(https://treeherder.mozilla.org/logviewer?job_id=478109916&repo=autoland&lineNumber=28766)

• Failure log for leaks

• this 2 TV jobs:

• https://treeherder.mozilla.org/logviewer?job_id=478106608&repo=autoland&lineNumber=22847

• https://treeherder.mozilla.org/logviewer?job_id=478106445&repo=autoland&lineNumber=26410

• Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/707bdf41cb27
[devtools] Enable Codemirror 6 by default r=devtools-reviewers,nchevobbe

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing lint failures @ browser/app/profile/firefox.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/891ea00ef03418b722de595c33b989a24c457702

Push with failures

Failure log -> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/app/profile/firefox.js:3022 | pref("devtools.debugger.features.codemirror-next", false);

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66ef699eddea
[devtools] Enable Codemirror 6 by default r=devtools-reviewers,nchevobbe

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures @ devtools/client/debugger/test/mochitest/<...>

Backout link: https://hg.mozilla.org/integration/autoland/rev/9dbd8d3782ee3f3240448773df628d1514b2c489

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-inline-exceptions-inline-script.js | Test timed out

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-columns.js | Test timed out

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e465cd047a62
[devtools] Enable Codemirror 6 by default r=devtools-reviewers,nchevobbe

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e465cd047a62

Comment 13

[Donal Meehan [:dmeehan]]

:bomsy could you consider nominating this for a release note? (Process info)
We could include it in the nightly only release notes.

Comment 14

[Hubert Boma Manilla (:bomsy)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Improved performance on in the devtools debugger editor.
[Affects Firefox for Android]: No
[Suggested wording]: The devtools debugger editor now uses Codemirror 6 only in Firefox Nightly. Devtools debugger users should see performance improvements with larger files.
[Links (documentation, blog post, etc)]:

Comment 15

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx133 nightly release notes, please allow 30 minutes for the site to update.

Comment 16

[Nicolas Chevobbe [:nchevobbe]]

Perfherder has detected a devtools performance change from push 4ce7e09dc04e6896eb36056159d5ba09e26cf7c9.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
36%	damp custom.jsdebugger.close.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	14.70 -> 19.93
29%	damp complicated.jsdebugger.reload.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	779.49 -> 1,008.43
18%	damp custom.jsdebugger.close.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	22.70 -> 26.80
18%	damp simple.jsdebugger.open.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	374.32 -> 439.85
15%	damp simple.jsdebugger.open.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	293.65 -> 337.43
14%	damp simple.jsdebugger.open.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	212.95 -> 243.21
14%	damp custom.netmonitor.exportHar	linux1804-64-shippable-qr	e10s fission stylo webrender	581.39 -> 663.41
12%	damp custom.netmonitor.exportHar	windows11-64-shippable-qr	e10s fission stylo webrender	261.25 -> 292.80
11%	damp cold.jsdebugger.open.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	488.73 -> 541.23
11%	damp custom.jsdebugger.open.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	687.58 -> 760.26
...	...	...	...	...
6%	damp browser-toolbox.webconsole-ready.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	402.55 -> 427.75
6%	damp custom.netmonitor.exportHar	macosx1015-64-shippable-qr	e10s fission stylo webrender	599.38 -> 634.12
4%	damp custom.jsdebugger.stepInNewSource.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	996.01 -> 1,036.51
4%	damp browser-toolbox.webconsole-ready.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	699.82 -> 725.21
3%	damp custom.jsdebugger.reload.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	445.35 -> 459.79

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
95%	damp custom.jsdebugger.open-large-minified-file.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	1,106.99 -> 58.58
93%	damp custom.jsdebugger.open-large-minified-file.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,264.05 -> 90.59
92%	damp custom.jsdebugger.open-large-minified-file.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	604.89 -> 47.18
78%	damp custom.jsdebugger.open-large-minified-file.full-selection.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,561.72 -> 350.20
73%	damp custom.jsdebugger.open-large-minified-file.full-selection.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	768.89 -> 210.99
...	...	...	...	...
2%	damp custom.jsdebugger.pretty-print.reload-and-pause.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	3,993.02 -> 3,905.51

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 2497

For more information on performance sheriffing please see our FAQ.