1900395 - Fix Failing tests to enable CM6

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Hubert Boma Manilla (:bomsy)]

Here is a TRY run https://treeherder.mozilla.org/jobs?repo=try&revision=f5ee1e1f86062f8a46abf3df69b52a23782b053e&selectedTaskRun=L9Hw-SN8RTaH_vxxVsj_dQ.0 with the test failures to fix for Codemirror 6

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Fixing mochitest for cm6 r=#devtools-reviewers

Depends on D215269

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Cleanup the selector list r=#devtools-reviewers

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Fix the gutter selectors and utils r=#devtools-reviewers

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Assert the correct mode for the file r=#devtools-reviewers

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Fix failing accessibility tests r=#devtools-reviewers

Comment 6

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Remove the breakpoint panel editor only in CM6 r=#devtools-reviewers

Comment 7

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Cleanup jest tests r=#devtools-reviewers

The Breakpoints and Coniditonal tests are not super useful as most of these are covered by mochitests.

The source-search and visible column breakpoints test have Codemirror 5 specific tests.
These should become less useful once we remove CM5 and add tests to the Source Editor.

Comment 8

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtool] Fix WASM for CM6 r=#devtools-reviewers

Comment 9

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Set cursor positon in the footer when doing file searches r=#devtools-reviewers

Comment 10

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Mark the last line in a blackboxed source r=#devtools-reviewers

Comment 11

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Fix displaying previews when jumping to original files r=#devtools-reviewers

Fixes browser_dbg-preview-source-maps.js

Comment 12

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Fix the Conditional breakpoint tests r=#devtools-reviewers

Comment 13

[Hubert Boma Manilla (:bomsy)]

Attachment: WIP: Bug 1900395 - [devtools] Fix scrolling tests

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/623b5f909135
[devtools] Set cursor positon in the footer when doing file searches r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/d5be8ed7de6b
[devtools] Mark the last line in a blackboxed source r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/0ec9e68b8495
[devtools] Remove the breakpoint panel editor only in CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/eef2cfaacedf
[devtools] Fix failing accessibility tests r=devtools-reviewers,nchevobbe

Comment 15

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/623b5f909135
https://hg.mozilla.org/mozilla-central/rev/d5be8ed7de6b
https://hg.mozilla.org/mozilla-central/rev/0ec9e68b8495
https://hg.mozilla.org/mozilla-central/rev/eef2cfaacedf

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a9995f71b0a
[devtools] Cleanup jest tests r=devtools-reviewers,nchevobbe

Comment 17

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3a9995f71b0a

Comment 18

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Use the source editor lineInfo API for CM6 r=#devtools-reviewers

Comment 19

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Fix the line wrapping for CM5 and CM6 r=#devtools-reviewers

Fixes browser_dbg-preview-wrapped-lines.js

Comment 20

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Setup the source editor used for testing r=#devtools-reviewers

Comment 21

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Add getLineCount utility r=#devtools-reviewers

Comment 22

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Migrate the waitForSearchState util to handle CM6 r=#devtools-reviewers

Comment 23

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Add a getContent util r=#devtools-reviewers

Comment 24

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Add a setEditorCursorAt util for setting the cursor r=#devtools-reviewers

Comment 25

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Migrate getEditorFileMode to use the util in the source editor r=#devtools-reviewers

Comment 26

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Add utility to support scrolling r=#devtools-reviewers

Comment 27

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Migrate the getCoordsFromPosition utility r=#devtools-reviewers

Comment 28

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Migrate setting selection utility r=#devtools-reviewers

Comment 29

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Migrate api for handling search r=#devtools-reviewers

Comment 30

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Rename posToOffset positionToOffset r=#devtools-reviewers

Comment 31

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Fix updating column breakpoints when they are clicked r=#devtools-reviewers

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1918241

Comment 32

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Migrate breakable line tests to handle CM6 r=#devtools-reviewers

Comment 33

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Migrate assertHighlightLocation to support CM6 r=#devtools-reviewers

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fca5c24595dd
[devtools] Setup the source editor used for testing r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/be6a2cb891d0
[devtools] Cleanup the selector list  r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8738f9b410de
[devtools] Fix the gutter selectors and utils r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/e1ca08240af2
[devtools] Assert the correct mode for the file r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/83ea834863a5
[devtools] Add getLineCount utility r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8330391d3908
[devtools] Migrate the waitForSearchState util to handle CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/7fca52925325
[devtools] Add a getContent util r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/b0d579588e9f
[devtools] Add a setEditorCursorAt util for setting the cursor r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c49d918a8d60
[devtools] Migrate getEditorFileMode to use the util in the source editor r=devtools-reviewers,nchevobbe

Comment 35

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/fca5c24595dd
https://hg.mozilla.org/mozilla-central/rev/be6a2cb891d0
https://hg.mozilla.org/mozilla-central/rev/8738f9b410de
https://hg.mozilla.org/mozilla-central/rev/e1ca08240af2
https://hg.mozilla.org/mozilla-central/rev/83ea834863a5
https://hg.mozilla.org/mozilla-central/rev/8330391d3908
https://hg.mozilla.org/mozilla-central/rev/7fca52925325
https://hg.mozilla.org/mozilla-central/rev/b0d579588e9f
https://hg.mozilla.org/mozilla-central/rev/c49d918a8d60

Comment 36

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Pref out using the lineHeight API only for CM5 r=#devtools-reviewers

Comment 37

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Import the utilities for use in the worker tests r=#devtools-reviewers

Comment 38

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Migrate assertIgnoredStyleInSourceLines to handles CM6 r=#devtools-reviewers

Comment 39

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Make assertPausedAtSourceAndLine async r=#devtools-reviewers

Comment 40

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] getTokenElAtLine and inline previews r=#devtools-reviewers

Comment 41

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Fix token utilities r=#devtools-reviewers

Comment 42

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Migrate breakpoint assertion and click functions to support CM6 r=#devtools-reviewers

Comment 43

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Cleanup leftover usages of getCM r=#devtools-reviewers

Comment 44

[Phabricator Automation]

Comment on attachment 9426341 [details]
Bug 1900395 - [devtools] Fix updating column breakpoints when they are clicked r=#devtools-reviewers

Revision D223059 was moved to bug 1918241. Setting attachment 9426341 [details] to obsolete.

Comment 45

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Some general fixes for tests r=#devtools-reviewers

Comment 46

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d755aed04871
[devtools] Add utility to support scrolling r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/50e5971e58f7
[devtools] Migrate the getCoordsFromPosition utility r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/7520078bc879
[devtools] Migrate setting selection utility r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c2206d5fb1aa
[devtools] Rename posToOffset positionToOffset r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ee8513f8c8a3
[devtools] Migrate breakable line tests to handle CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/647fb47e8c33
[devtools] Migrate assertHighlightLocation to support CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/4ef9e765dbcb
[devtools] Use the source editor lineInfo API for CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8b8dc9c00a8c
[devtools] Fix the Conditional breakpoint tests r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/af2e38994b34
[devtools] Fix the line wrapping for CM5 and CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/3de72d16955d
[devtools] Pref out using the lineHeight API only for CM5 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2dc1ddefcf04
[devtools] Import the utilities for use in the worker tests r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/95947b399560
[devtools] Migrate assertIgnoredStyleInSourceLines to handles CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/cd15f5429cdf
[devtools] Make assertPausedAtSourceAndLine async r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2e8f2a91f5c1
[devtools] getTokenElAtLine and inline previews r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/532f750e2c54
[devtools] Fix token utilities r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/09dc669541de
[devtools] Migrate api for handling search r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/dd22a3b092ae
[devtools] Migrate breakpoint assertion and click functions to support CM6 r=devtools-reviewers,nchevobbe

Comment 47

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1900395 - [devtools] Fix keyboard navigation and outline tests r=#devtools-reviewers

Comment 48

[tszentpeteri]

Backed out for causing dt failures related to browser_dbg.

• Backout link
• Push with failures
• Failure Log 1
• Failure Log 2
• Failure Log 3
• Failure Log 4
• Failure Log 5
• Failure Log 6
• Failure Log 7

[task 2024-10-10T07:14:20.002Z] 07:14:20     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-editor-scroll.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2024-10-10T07:14:20.002Z] 07:14:20     INFO - finish() was called, cleaning up and clearing debugger preferences...
[task 2024-10-10T07:14:20.002Z] 07:14:20     INFO - Buffered messages finished
[task 2024-10-10T07:14:20.003Z] 07:14:20     INFO - TEST-UNEXPECTED-PASS | devtools/client/debugger/test/mochitest/browser_dbg-editor-scroll.js | We expect at least one assertion to fail because this test file is marked as fail-if in the manifest. - 
[task 2024-10-10T07:14:20.003Z] 07:14:20     INFO - TEST-INFO | expected FAIL
[task 2024-10-10T07:14:20.003Z] 07:14:20     INFO - GECKO(1066) | MEMORY STAT | vsize 12638MB | residentFast 788MB | heapAllocated 436MB
[task 2024-10-10T07:14:20.004Z] 07:14:20     INFO - TEST-OK | devtools/client/debugger/test/mochitest/browser_dbg-editor-scroll.js | took 2765ms
[task 2024-10-10T07:14:20.004Z] 07:14:20     INFO - checking window state
[task 2024-10-10T07:14:20.005Z] 07:14:20     INFO - TEST-START | devtools/client/debugger/test/mochitest/browser_dbg-editor-select.js

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34683c060e81
[devtools] Add utility to support scrolling r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/d2fcfd22e228
[devtools] Migrate the getCoordsFromPosition utility r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2b7eaaf580cc
[devtools] Migrate setting selection utility r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/b2a275536bb8
[devtools] Rename posToOffset positionToOffset r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/5eb9b67d72ee
[devtools] Migrate breakable line tests to handle CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/09b7834d5858
[devtools] Migrate assertHighlightLocation to support CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c5e546f0a1df
[devtools] Use the source editor lineInfo API for CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/4d8edf492c48
[devtools] Fix the Conditional breakpoint tests r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/e203cd18a1f2
[devtools] Fix the line wrapping for CM5 and CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/44222458df50
[devtools] Pref out using the lineHeight API only for CM5 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/5e10d5df7db7
[devtools] Import the utilities for use in the worker tests r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/643d32a8b2b9
[devtools] Migrate assertIgnoredStyleInSourceLines to handles CM6 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/3d92e0a72eeb
[devtools] Make assertPausedAtSourceAndLine async r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/643efdee8e37
[devtools] getTokenElAtLine and inline previews r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/1d48b1aa7779
[devtools] Fix token utilities r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/4eaec9d5a2c5
[devtools] Migrate api for handling search r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/e3e86ef9349f
[devtools] Migrate breakpoint assertion and click functions to support CM6 r=devtools-reviewers,nchevobbe

Comment 50

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/34683c060e81
https://hg.mozilla.org/mozilla-central/rev/d2fcfd22e228
https://hg.mozilla.org/mozilla-central/rev/2b7eaaf580cc
https://hg.mozilla.org/mozilla-central/rev/b2a275536bb8
https://hg.mozilla.org/mozilla-central/rev/5eb9b67d72ee
https://hg.mozilla.org/mozilla-central/rev/09b7834d5858
https://hg.mozilla.org/mozilla-central/rev/c5e546f0a1df
https://hg.mozilla.org/mozilla-central/rev/4d8edf492c48
https://hg.mozilla.org/mozilla-central/rev/e203cd18a1f2
https://hg.mozilla.org/mozilla-central/rev/44222458df50
https://hg.mozilla.org/mozilla-central/rev/5e10d5df7db7
https://hg.mozilla.org/mozilla-central/rev/643d32a8b2b9
https://hg.mozilla.org/mozilla-central/rev/3d92e0a72eeb
https://hg.mozilla.org/mozilla-central/rev/643efdee8e37
https://hg.mozilla.org/mozilla-central/rev/1d48b1aa7779
https://hg.mozilla.org/mozilla-central/rev/4eaec9d5a2c5
https://hg.mozilla.org/mozilla-central/rev/e3e86ef9349f

Comment 51

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/684b1d17a805
[devtools] Cleanup leftover usages of getCM r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/6509640f583b
[devtools] Some general fixes for tests r=devtools-reviewers,nchevobbe

Comment 52

[Iulian Moraru]

Backed out 4 changesets (bug 1900395, bug 1904489, bug 1920928) for causing multiple dt failures.

• Push with failures

• Failure log for failures on browser_dbg-preview.js

• Failure log for failures on browser_dbg-blackbox.js

• [Failure log for failures on browser_target_command_service_workers_navigation.js(https://treeherder.mozilla.org/logviewer?job_id=478109916&repo=autoland&lineNumber=28766)

• Failure log for leaks

• this 2 TV jobs:

• https://treeherder.mozilla.org/logviewer?job_id=478106608&repo=autoland&lineNumber=22847

• https://treeherder.mozilla.org/logviewer?job_id=478106445&repo=autoland&lineNumber=26410

• Backout link

Comment 53

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8e1ead1faa1
[devtools] Cleanup leftover usages of getCM r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/374dce0b2a08
[devtools] Some general fixes for tests r=devtools-reviewers,nchevobbe

Comment 54

[Sandor Molnar[:smolnar]]

Backed out for causing lint failures @ browser/app/profile/firefox.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/891ea00ef03418b722de595c33b989a24c457702

Push with failures

Failure log -> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/app/profile/firefox.js:3022 | pref("devtools.debugger.features.codemirror-next", false);

Comment 55

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f9276eaa16d
[devtools] Cleanup leftover usages of getCM r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c10ce9412d2a
[devtools] Some general fixes for tests r=devtools-reviewers,nchevobbe

Comment 56

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures @ devtools/client/debugger/test/mochitest/<...>

Backout link: https://hg.mozilla.org/integration/autoland/rev/9dbd8d3782ee3f3240448773df628d1514b2c489

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-inline-exceptions-inline-script.js | Test timed out

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-columns.js | Test timed out

Comment 57

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85d48257458e
[devtools] Cleanup leftover usages of getCM r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/cad2bc3a2d2d
[devtools] Some general fixes for tests r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/dd38d70a8348
[devtools] Fix keyboard navigation and outline tests r=devtools-reviewers,ochameau

Comment 58

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/85d48257458e
https://hg.mozilla.org/mozilla-central/rev/cad2bc3a2d2d
https://hg.mozilla.org/mozilla-central/rev/dd38d70a8348

Comment 59

[Phabricator Automation]

Comment on attachment 9422157 [details]
Bug 1900395 - [devtool] Fix WASM for CM6 r=#devtools-reviewers

Revision D220850 was moved to bug 1935157. Setting attachment 9422157 [details] to obsolete.