1904958 - Fenix's find-in-page UI gets covered up by bottom toolbar, in App Tab, after you switch apps away and back

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect)

Description

[Daniel Holbert [:dholbert]]

[EDIT: See slightly-better STR in comment 12, getting a bit more to-the-point here]

Steps to reproduce

1. Set Firefox as your default browser.
2. Tap a link to a PDF in your email, e.g. this link: https://www.adobe.com/support/products/enterprise/knowledgecenter/media/c4611_sample_explain.pdf
3. In the Firefox "App Tab" that appears, tap the 3-dot-menu and select "Find in page"
4. Type a word that you see in the PDF, e.g. "prepared", and then tap the downarrow at bottom-left to hide your keyboard. (Notice that the match gets visually highlighted in the PDF.)
5. Swipe up from the bottom of your screen (the Android "home" gesture) to put the app in the background.
6. Tap your email app icon to return to seeing the App Tab that you were just looking at.

Expected behavior

The app tab should look identical at the end of step 4 & step 6 (with find-in-page active and visible)

Actual behavior

At the end of step 6, the find-in-page UI is active but the search bar is covered up! You can tell it's active because:

• the find-in-page match ("Prepared") is still highlighted.
• if you have scroll-to-hide dynamic toolbar enabled (default), then you can also see the findbar's buggy blank area (described in bug 1904951) sticking up from the bottom toolbar, from the covered-up findbar.

...but you can't actually see the searchbar itself (which also means there's no way to tap its "x" to cancel out of it; though you can force it to reappear by reactivating it as described in step 3).

Device information

• Firefox version: 129.0a1 2024-06-25
• Android device model: Pixel 8
• Android OS version: 14

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot showing the broken final rendering

Here's a screenshot showing the broken final rendering.

Notice:

• the word "prepared" is highlighted at the top as a find-in-page match (indicating that find-in-page is still active)
• the blank area sticking up from the toolbar at the bottom (which is a manifestation of bug 1904951 granting a little hat to the find-in-page searchbar)
• ...BUT the find-in-page searchbar itself isn't visible; it's covered up by the bottom toolbar.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

Comment 3

[Daniel Holbert [:dholbert]]

To see the bug in the attached screencast, compare the renderings at t=12s to t=14s. The expectation is that the UI should look exactly the same, but it's not; the bottom toolbar is hidden at t=12s, but it's present at t=14s, and it's covering up the find-in-page searchbar as discussed above.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: screencast of another bug, ignore me

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 9409801 [details]
screencast of another bug, ignore me

(sorry, comment 4's screencast was meant for another bug -- bug 1904970.)

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Roger Yang [:royang]]

Reproducible.

Comment 8

[Roger Yang [:royang]]

This could be related/duplicate of Bug 1904951. The main issue here is custom tab doesn't remember that the user is in the "find in page" state. So when leaving Fenix and coming back we're actually not in a "find in page" state.

Comment 9

[Roger Yang [:royang]]

Attachment: Screen_recording_20240711_122805.mp4

Looks like this is not just a PDF issue but a custom tab issue. When we leave and come back to Fenix, we're still in a "find in page" state. This can be confirmed by seeing the search term still highlighted.

Moving it back to Fenix.

Comment 10

[Daniel Holbert [:dholbert]]

You can see the find-in-page bottom-toolbar being uncovered/revealed by the find-in-page toolbar as you scroll, too. (Part of the issue is that the dynamic toolbar is covering it up.)

This doesn't seem to be specific to PDF-viewer, either; it's just easier to see with the PDF viewer since the find-in-page UI overflows with the blank gray area there, per Bug 1904951.

Comment 11

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug reproducing with a regular web page

Comment 12

[Daniel Holbert [:dholbert]]

BETTER STR (not using a PDF, to help distinguish this from Bug 1904951):

1. Set Firefox as your default browser, and make sure you have the dynamic toolbar enabled ("Scroll to hide address bar")
2. In your email app, tap a link to this bug page (any page is fine, but let's use this one).
3. In the Firefox "App Tab" that appears, tap the 3-dot-menu and select "Find in page".
4. Type a term e.g. "repro"
5. Swipe up from the bottom of your screen (the Android "home" gesture) to put the app in the background.
6. Tap your email app icon to return to seeing the App Tab that you were just looking at.
7. Slowly scroll the page down/up, and watch for findbar UI.

EXPECTED RESULTS:
The app tab should look identical at the end of step 4 & in step 6-7 (with find-in-page active and visible).

ACTUAL RESULTS:
At the end of step 6, the find-in-page UI is active but the search bar is covered up! You can tell it's active because it gets revealed when you scroll in step 7 (and because the find-in-page match is still highlighted)

The screencast that I just attached in comment 11 show the ACTUAL RESULTS.

Comment 13

[Delia Pop (Android QA)]

Attachment: FindinPage_CustomTab_Nightly132.mp4

This issue is no longer reproducible on the latest Nightly 132.0a1 from 09/12 with and without the Toolbar Redesign enabled.
Not reproducible in latest Beta 131.0b5 or Release 130.0, where only the issue of the additional space displayed above the find in page bar remains.

Tested with the following devices:

• Samsung Galaxy A53 5G (Android 14)
• Xiaomi 12 Pro (Android 13)
• Samsung Tab S8 Ultra 5G (Android 14)

Closing as fixed.