1905014 - stripEmail fails when email has comment after

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Magnus Melin [:mkmelin]]

Per matrix, reading Kai's email on tb-planning results in

2avaScript error: chrome://openpgp/content/modules/funcs.sys.mjs, line 63: Error: Invalid <..> brackets in mail address: "Kai Engert via Thunderbird Planning"
<[e-mail]> (Thunderbird)

https://searchfox.org/comm-central/rev/cfb5f868a055ac2a247dd48a5444cfea3c7dd648/mail/extensions/openpgp/content/modules/funcs.sys.mjs#31

This should be using our standard parsing methods instead.

Comment 1

[Kai Engert [:KaiE:]]

working on it.

Comment 2

[Kai Engert [:KaiE:]]

Attachment: Bug 1905014 - Use global code for email name parsing, remove incomplete code from OpenPGP code. r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b4fc5156df08
Use global code for email name parsing, remove incomplete code from OpenPGP code. r=mkmelin

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9409958 [details]
Bug 1905014 - Use global code for email name parsing, remove incomplete code from OpenPGP code. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): uncertain
User impact if declined: error on console, incomplete code execution, uncertain failures
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): small risk. We're reusing existing common code. Side effects would be limited to OpenPGP code.

Comment 5

[Corey Bryant]

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 128.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/19439df94f23

Comment 7

[Francesco]

landed on beta before the esr merge.