1905060 - Focus outlines (highlights) are cut off on some buttons in the reader mode control popup when using keyboard navigation

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, defect, P3)

Description

[Negritas Sergiu, Desktop QA]

Found in

• 129.0a1 (2024-06-28)

Affected versions

• 129.0a1 (2024-06-27)

Tested platforms

• Affected platforms:
  • Windows 10
  • Ubuntu 22.04
  • MacOS 13, MacOS 12.6, MacOS 11.6

Steps to reproduce

1. Open Firefox and navigate to wikipedia.com
2. Enable Reader view and access the Text customization menu
3. Using keyboard navigation go through all the options.
4. Observe the Highlight over every button.

Expected result

• Highlight is properly shown around the buttons.

Actual result

• The Highligh is cut around the Advanced and Restore defaults buttons

Additional notes

• Also in the Theme menu the highlight for Restore defaults button is overflowing on the left side of the Theme menu.
• Please see the attached video.

Comment 1

[Negritas Sergiu, Desktop QA]

Attachment: Screencast from 27.06.2024 15:07:53.webm

Comment 2

[:Gijs (out for now; he/him)]

Looks like some of these items could do with a better balance between padding and margin.

Irene, is this something you have time to pick up?

Comment 3

[Irene Ni]

Attachment: Bug 1905060 - fix cut off focus outlines on certain buttons when using keyboard navigation. r=#reader-mode-reviewers

Comment 4

[Irene Ni]

Gave this a try by redistributing all the margins on both top and bottom.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78a8e6fde02e
fix cut off focus outlines on certain buttons when using keyboard navigation. r=reader-mode-reviewers,desktop-theme-reviewers,cmkm

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/78a8e6fde02e

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ini, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Irene Ni]

Since this is an S4 and only affects 2 buttons, I won't request uplift.

Comment 9

[Negritas Sergiu, Desktop QA]

Hello! I can confirm that this issue is fixed with firefox 130.0b1 on Ubuntu 22.04, MacOS 12.6 and Windows 10. I will update the status and flags.

Have a nice day!