1905157 - Throw constant values when recovering and map those constants to localized error messages.

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Fred Chasen [:fchasen]]

We should convert the exceptions that are throw during the recoverFromBackupArchive process to throw constant values inside of the cause property of the errors. Those constants should be in ArchiveUtils if possible.

Will also need to map the constants to the right localized error message string to display in Bug 1905154 or a generic error message string.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Those constants should be in ArchiveUtils if possible.

I thought about it a bit more, and considering that we might want those constants to be available inside some of our UI components, we might want to create a new non .sys module that just contains constants. BackupConstants.mjs or something.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Bug 1904949 added a bunch of cause values for exceptions thrown in BackupService, so that part is done. This bug is about making sure those constants get mapped to friendly error messages to users.

Comment 3

[Stephen Thompson]

Attachment: Bug 1905157 - Display profile recovery error messages in UI r=#backup-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/898c9afa27d2
Display profile recovery error messages in UI r=backup-reviewers,fluent-reviewers,mconley,bolsson

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages

Backout link

Push with failures

Failure log

Comment 7

[Stephen Thompson]

I was explicitly packaging a single JS file using both moz.build and jar.mn in order to use the file from different contexts. I did not know that this type of duplication was discouraged.

I am working on an alternative solution to packaging the single JS file once.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1e54375ddf5
Display profile recovery error messages in UI r=backup-reviewers,fluent-reviewers,mconley,bolsson,kpatenio

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d1e54375ddf5