1905172 - UX updates for closing tabs remotely feature

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Sammy Khamis [:skhamis]]

Based on the feedback from design, there are a few tweak we'll need to do around the closing tabs remotely feature.

Feedback so far:

1. Hover background-color state of close and undo button should match the hover of the tab buttons
2. Alignment of close buttons should match with chevron of inactive tabs
3. Weight of undo icon is too heavy compared to close icon
   • Replace the undo as an icon and make it a text button
4. Close button is not square when hovered/clicked

Comment 1

[Sammy Khamis [:skhamis]]

Attachment: Bug 1905172: UI tweaks to closing tabs remotely r?markh

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90c2e1d8606b
UI tweaks to closing tabs remotely r=markh,desktop-theme-reviewers,jules,dao

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/90c2e1d8606b

Comment 4

[Sammy Khamis [:skhamis]]

Attachment: Bug 1905172: UI tweaks to closing tabs remotely r=#sync-reviewers

Comment 5

[Sammy Khamis [:skhamis]]

Attachment: Screen Shot 2024-07-03 at 1.08.01 PM.png

UX Feedback:

1. Disable hover & click events when user clicks the "X" button and only allow them to click undo
2. Make icon colors consistent
3. Close icon hover should be consistent with the other buttons
4. Inactive and show more tabs should be left aligned with other buttons in the list
5. Height/padding of "No open tabs" should match other buttons on the list (currently too close to header)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b03d74017bff
UI tweaks to closing tabs remotely r=sync-reviewers,desktop-theme-reviewers,markh,sfoster

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b03d74017bff

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:skhamis, could you have a look please?

For more information, please visit BugBot documentation.