1905379 - Maybe remove regRename pref check when deciding whether to set default guidance notification check and update tests

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

Investigate whether we can remove the check for the ...regRename pref [here](https://searchfox.org/mozilla-central/source/browser/components/shell/ShellService.sys.mjs#331-333. Theoretically, it will only fall through to the _maybeShowSetDefaultGuidanceNotification if both versions of the one-click Windows set default workaround fail.

In shell/test/browser_setDefaultBrowser.js the value of setDefaultBrowserUserChoice should match the value of setDefaultBrowserUserChoiceRegRename as the latter workaround changing the ancestor registry key only occurs as a fallback when setDefaultBrowserUserChoice is true and the original workaround fails.

These changes don't affect the user experience and do not need to be uplifted into FX128 like the original patch from Bug 1903416.

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1905379 - Clean up set default guidance notification check and update tests

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50043205a8aa
Clean up set default guidance notification check and update tests r=nrishel

Comment 3

[tszentpeteri]

Backed out for causing mochitest failures on browser_download_preferred_action.js and browser_searchTips.js

• Backout link
• Push with failures
• Failure Log for browser_searchTips.js
• Failure Log browser_download_preferred_action.js:

[task 2024-07-02T16:15:39.634Z] 16:15:39     INFO - TEST-PASS | uriloader/exthandler/tests/mochitest/browser_download_preferred_action.js | Download should not be saved to disk - 
[task 2024-07-02T16:15:39.635Z] 16:15:39     INFO - Testing download with mime-type application/pdf and extension pdf, preferred action "Use System Default," and Content-Disposition: attachment header.
[task 2024-07-02T16:15:39.635Z] 16:15:39     INFO - Preparing for download...
[task 2024-07-02T16:15:39.636Z] 16:15:39     INFO - Start download of https://example.com/browser/uriloader/exthandler/tests/mochitest/mime_type_download.sjs?contentType=application/pdf&extension=pdf&withHeader
[task 2024-07-02T16:15:39.637Z] 16:15:39     INFO - Wait for download to finish...
[task 2024-07-02T16:15:39.638Z] 16:15:39     INFO - Console message: [JavaScript Warning: "sizeToContent() is deprecated and will be removed in the future." {file: "resource://gre/modules/HelperAppDlg.sys.mjs" line: 876}]
[task 2024-07-02T16:15:39.638Z] 16:15:39     INFO - Buffered messages finished
[task 2024-07-02T16:15:39.639Z] 16:15:39     INFO - TEST-UNEXPECTED-FAIL | uriloader/exthandler/tests/mochitest/browser_download_preferred_action.js | Test timed out - 
[task 2024-07-02T16:15:39.639Z] 16:15:39     INFO - GECKO(8832) | Completed ShutdownLeaks collections in process 5192
[task 2024-07-02T16:15:39.640Z] 16:15:39     INFO - TEST-START | Shutdown

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4244cdbbd556
Clean up set default guidance notification check and update tests r=nrishel,negin

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/4244cdbbd556

Comment 6

[Meg Viar [:mviar]]

Fix has landed.