1905463 - Cap aspect-ratio's automatic minimum size by its maximum size

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Per https://drafts.csswg.org/css-sizing-4/#aspect-ratio-minimum,

In order to avoid unintentional overflow, the automatic minimum size in the ratio-dependent axis of a box with a preferred aspect ratio that is neither a replaced element nor a scroll container is its min-content size capped by its maximum size.

We've implemented the automatic minimum size, but we don't seem to cap the size by the maximum size. Therefore, we fail https://wpt.live/css/css-sizing/aspect-ratio/block-aspect-ratio-038.html and https://wpt.live/css/css-sizing/aspect-ratio/block-aspect-ratio-039.html

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1905463 - Cap aspect-ratio's automatic minimum size by the maximum size. r?#layout

The flex container and grid container have already considered max sizes clamping
when computing their sizes. Therefore, flex-aspect-ratio-043.html,
flex-aspect-ratio-044.html, and grid-aspect-ratio-042.html already pass on
the current Nightly without this patch.

• flex-aspect-ratio-043.html and flex-aspect-ratio-044.html are adapted from
  flex-aspect-ratio-040.html and flex-aspect-ratio-041.html.
• grid-aspect-ratio-042.html is adapted from grid-aspect-ratio-039.html.
• fieldset-element-002.html is adapted from fieldset-element-001.html.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e14640934441
Cap aspect-ratio's automatic minimum size by the maximum size. r=layout-reviewers,emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46954 for changes under testing/web-platform/tests

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/e14640934441

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot