1905672 - [Experiment][Treatment B] The default browser OS settings page is triggered after the “Open my links with Firefox” button from the “Fox Doodle” spotlight is clicked

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Alice Varro [avarro], Ecosystem QA]

Attachment: treatment B.gif

[Affected versions]:

• Firefox build version: Firefox Beta 128.0b9 (Release channel), Build ID: 20240628091536

[Affected Platforms]:

• Windows 10 x64;
• Windows 11 x64;

[Prerequisites]:

• Have the Firefox build installed on your computer.
• Firefox is not set as default.
• Have the “times.json” file and the “user.js” file downloaded on your computer.

[Steps to reproduce]:

1. Create a new Firefox profile but do not open it.
2. Add the “times.json” file and “user.js” file to the profile folder.
3. Open the Firefox profile.
4. Click the “Open my links with Firefox” button from the “Fox Doodle” spotlight.
5. Observe the behavior.

[Expected result]:

• Firefox is set as default and the default browser OS settings page is not triggered.

[Actual result]:

• The default browser OS settings page is triggered after the button is clicked.

[Notes]:

• According to the documentation of the experiment for the Treatment B, the branch configuration should be 1-click only, meaning that the Firefox should be set as the default and the OS settings page should not be displayed after the primary button of the Fox Doodle spotlight is clicked.
• Attaching a screen recording of the issue.

Comment 1

[Meg Viar [:mviar]]

@Alice, Negin is out today, but I tried the one-click default from branch B locally on Windows 11 Pro Version 23H2, OS build 22631.3737 and did not see the same result.

Can you confirm whether one-click set to default works on your builds (fresh copy of beta, no experiment enrollment, not already set to default) with the prefs browser.shell.setDefaultBrowserUserChoice.regRename and browser.shell.setDefaultBrowserUserChoice both set to true (and ensuring browser.shell.checkDefault is also true)? In about:asrouter you can trigger the `FOX_DOODLE_SET_DEFAULT" message and click the button to set to default to test.

Then, can you attempt the same as above, but with browser.shell.setDefaultBrowserUserChoice.regRename set to false and let us know whether that allows set to default with one-click or if you see the OS setting there are well?

Thanks for you help with this.

Comment 2

[Alice Varro [avarro], Ecosystem QA]

Hi Meg!
We've verified on Firefox Beta 128.0b9 and Firefox RC 128 using the steps you provided and the outcome is the following:

• By setting all of the prefs from comment 1 to true the one-click works as expected and the OS setting is not triggered.
• By setting "browser.shell.setDefaultBrowserUserChoice.regRename" to false and the rest to true using Windows Sandbox the one-click worked as expected but without Sandbox the OS setting was triggered and even the guidance notification too.
  The Windows versions used were: Windows 10 Home, version 22H2, OS build 19045.4529 and Windows 11 Enterprise version 23H2, OS build 22631.3737
  On both devices the Firefox build was fresh installed.

Comment 3

[Alice Varro [avarro], Ecosystem QA]

Attachment: Os + notification.gif

Attaching a screen recording for the case where browser.shell.setDefaultBrowserUserChoice.regRename pref was set to false

Comment 4

[Alice Varro [avarro], Ecosystem QA]

I've verified again this issue by being enrolled in the Treatment B of the experiment after we put 1-Click Set to Default - Existing Profiles - no spotlight experiment back to draft due to some conflict that happened with 1-Click Set to Default - Existing Profiles experiment. The 1-click only works as expected now.
Thanks for the help! I'll close this issue now.