1906093 - Create a singleton per task id

Status: RESOLVED FIXED

(Core :: Machine Learning, enhancement)

Description

[Tarek Ziadé (:tarek)]

For now we want to make sure that we only create one worker per task to avoid loading many workers in memory

Comment 1

[Tarek Ziadé (:tarek)]

Attachment: Bug 1906093 - added engineId to avoid duplicated engines - r?gregtatum

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8bb74db1fd8
added engineId to avoid duplicated engines - r=gregtatum

Comment 3

[tszentpeteri]

Backed out for causing mochitest failures on browser_ml_engine.js

• Backout link
• Push with failures
• Failure Log:

[task 2024-07-31T09:15:30.965Z] 09:15:30     INFO - TEST-PASS | toolkit/components/ml/tests/browser/browser_ml_engine.js | The engine process is still active. - 
[task 2024-07-31T09:15:30.966Z] 09:15:30     INFO - Buffered messages finished
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/ml/tests/browser/browser_ml_engine.js | Uncaught exception in test bound test_ml_dupe_engines - InvalidStateError: JSWindowActorParent.sendAsyncMessage: JSWindowActorParent cannot send at the moment
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - Stack trace:
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - #setupPortCommunication@resource://gre/actors/MLEngineParent.sys.mjs:437:25
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - MLEngine@resource://gre/actors/MLEngineParent.sys.mjs:425:33
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - getEngine@resource://gre/actors/MLEngineParent.sys.mjs:124:22
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - async*createEngine@chrome://global/content/ml/EngineProcess.sys.mjs:482:23
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - async*test_ml_dupe_engines@chrome://mochitests/content/browser/toolkit/components/ml/tests/browser/browser_ml_engine.js:405:31
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1145:26
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1217:18
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1358:14
[task 2024-07-31T09:15:30.967Z] 09:15:30     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1134:14
[task 2024-07-31T09:15:30.968Z] 09:15:30     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-07-31T09:15:30.968Z] 09:15:30     INFO - Leaving test bound test_ml_dupe_engines
[task 2024-07-31T09:15:30.968Z] 09:15:30     INFO - Entering test bound test_ml_engine_override_options
[task 2024-07-31T09:15:30.969Z] 09:15:30     INFO - GECKO(5695) | console.log: ML:EngineParent: "Mocking remote settings in MLEngineParent."
[task 2024-07-31T09:15:30.969Z] 09:15:30     INFO - Get the engine
[task 2024-07-31T09:15:30.970Z] 09:15:30     INFO - GECKO(5695) | console.debug: ML:EngineParent: "Creating a new engine"
[task 2024-07-31T09:15:30.970Z] 09:15:30     INFO - Check the inference process is running
[task 2024-07-31T09:15:30.971Z] 09:15:30     INFO - TEST-PASS | toolkit/components/ml/tests/browser/browser_ml_engine.js | true == true - 

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2834f6fca5a
added engineId to avoid duplicated engines - r=gregtatum

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e2834f6fca5a