1913768 - browser_ml_engine.js missing arguments to EngineDispatcher's terminate method

Status: RESOLVED FIXED

(Core :: Machine Learning, defect)

Description

[Andrew McCreight [:mccr8]]

Bug 1906093 added two arguments to the terminate method of EngineDispatcher, but it did not add those arguments to one of the calls to terminate in the test browser_ml_engine.js, which means that shutDownIfEmpty and replacement end up as undefined, which in turn means that we end up sending undefined for those fields in the JS actor message MLEngine:Removed.

I don't see any specific problem from this, as I guess the undefined acts as false anyways, but it does mean a value is getting passed around that doesn't match the type in the comments.

I came across this while looking at types for JS actor messages in bug 1885221.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1906093

:tarek, since you are the author of the regressor, bug 1906093, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Andrew McCreight [:mccr8]]

Apparently a regression can't be a task, but this is test-only so I'll mark it S4. I assume if I mark it N/A then the bots will also get mad somehow.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1913768 - Add missing arguments to EngineDispatcher's terminate method in browser_ml_engine.js

By default, these arguments will end up as undefined, so passing in true for
the first one will change the behavior, but it looks like shutting down
the engine is the desired behavior here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec1079c0bdf0
Add missing arguments to EngineDispatcher's terminate method in browser_ml_engine.js r=tarek

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/ec1079c0bdf0