1906106 - Emit a single network.responseCompleted event for authentication flows

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Julian Descottes [:jdescottes]]

At the moment the BiDi + fetch spec expects that only a single network.responseCompleted event should be emitted when we have an authentication sequence, regardless of the number of authentication attempts.

It is unclear if we want to keep this behavior in the long run, Bug 1899604 will be about tracking the related spec discussion and implementing the changes if need be.

This will unblock the "network Page.authenticate should allow disable authentication" puppeteer test.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1906106 - [bidi] Only emit a single responseCompleted event for an authentication flow

This is compliant with the current specification. All authentication request attempts for the same original request share the same request id, and only a single responseCompleted event should be
emitted.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1906106 - [wdspec] Update continueWithAuth tests to check for a single responseCompleted

Depends on D215623

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/593b97c86729
[bidi] Only emit a single responseCompleted event for an authentication flow r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/cb195cae29c6
[wdspec] Update continueWithAuth tests to check for a single responseCompleted r=webdriver-reviewers,whimboo

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46998 for changes under testing/web-platform/tests

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/593b97c86729
https://hg.mozilla.org/mozilla-central/rev/cb195cae29c6

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot