1906432 - Error message in CardDAV dialog is unreadable with dark theme

Status: VERIFIED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: image.png

Open the AB tab, create a new CardCAV and enter invalid values into the fields and press Continue.

With light theme the appearing error message is readable but with dark theme it's white on yellow.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1906432 - Fix the text error color in CardDAV dialog. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a51b7dc70cdd
Fix the text error color in CardDAV dialog. r=#thunderbird-front-end-reviewers

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9411370 [details]
Bug 1906432 - Fix the text error color in CardDAV dialog. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
User impact if declined: with dark theme unreadable error message in LDAP dialog
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9411370 [details]
Bug 1906432 - Fix the text error color in CardDAV dialog. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta
Approved for esr128

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 129.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b5da00e9c3fb

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 128.0.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/41793a2f53b5

Comment 7

[Ramona Gavrilescu]

Confirming this issue as verified fixed for 128.0.1esr(20240717233102) using macOS 14.