Closed
Bug 1906541
Opened 2 years ago
Closed 2 years ago
Ensure Searchmode Switcher works when Search Services fails
Categories
(Firefox :: Address Bar, defect, P3)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
133 Branch
| Tracking | Status | |
|---|---|---|
| firefox133 | --- | fixed |
People
(Reporter: daleharvey, Assigned: yazan)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sng])
Attachments
(1 external file)
No description provided.
Updated•2 years ago
|
Whiteboard: [sng]
Updated•2 years ago
|
Comment 1•2 years ago
|
||
One thing to check here is that when UrlbarSearchUtils fails, engine will be null in many cases.
getDisplayedEngineDetails still tries to use engine.name.
When invoking this.searchModeSwitcher.onSearchModeChanged() errors may cause an exception that would break external code.
Probably the onSearchModeChanged call should either be in a try/catch or catched internally.
| Assignee | ||
Updated•2 years ago
|
Assignee: nobody → yalmacki
| Reporter | ||
Updated•2 years ago
|
Summary: Ensure Searchmode Switcher works when Search Services fails + keyword.enabled = false → Ensure Searchmode Switcher works when Search Services fails
| Assignee | ||
Comment 2•2 years ago
|
||
Pushed by yalmacki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88669d7958cf
Ensure Searchmode Switcher works when Search Services fails. r=daleharvey,urlbar-reviewers,fluent-reviewers,mak
Comment 4•2 years ago
|
||
Backed out for causing bc failure on browser_searchModeSwitcher_basic.js
Flags: needinfo?(yalmacki)
Pushed by yalmacki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8849b9f46f2
Ensure Searchmode Switcher works when Search Services fails. r=daleharvey,urlbar-reviewers,fluent-reviewers,mak
| Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(yalmacki)
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Comment 7•1 year ago
|
||
This fix was covered and subsequently verified by the Unified Desktop Search Button QA-2542 feature run during Scotch Bonnet sign-off.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•