1906541 - Ensure Searchmode Switcher works when Search Services fails

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Comment 1

[Marco Bonardo [:mak]]

One thing to check here is that when UrlbarSearchUtils fails, engine will be null in many cases.
getDisplayedEngineDetails still tries to use engine.name.

When invoking this.searchModeSwitcher.onSearchModeChanged() errors may cause an exception that would break external code.
Probably the onSearchModeChanged call should either be in a try/catch or catched internally.

Comment 2

[Yazan Al Macki [:yazan]]

Attachment: Bug 1906541 - Ensure Searchmode Switcher works when Search Services fails. r?daleharvey

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88669d7958cf
Ensure Searchmode Switcher works when Search Services fails. r=daleharvey,urlbar-reviewers,fluent-reviewers,mak

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing bc failure on browser_searchModeSwitcher_basic.js

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8849b9f46f2
Ensure Searchmode Switcher works when Search Services fails. r=daleharvey,urlbar-reviewers,fluent-reviewers,mak

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/e8849b9f46f2

Comment 7

[Petruta Horea [:phorea]]

This fix was covered and subsequently verified by the Unified Desktop Search Button QA-2542 feature run during Scotch Bonnet sign-off.