1906681 - [Menu Redesign] Install menu text is wrong for PWAs

Status: RESOLVED FIXED

(Firefox for Android :: PWA, defect, P3)

Description

[Jonathan Almeida [:jonalmeida]]

Steps to reproduce

1. Visit bmw.com
2. Observe the three-dot menu.

Expected behaviour

• The manifest is downloaded and parsed (observe in dev tools).
• The menu should show 'Install' when the PWA manifest is available.

Actual behaviour

• The manifest is downloaded and parsed (observe in dev tools).
• The menu does NOT show 'Install' when the PWA manifest is available.

Device information

• Firefox version: 129.0a1
• Android device model: Samsung SM-A515F
• Android OS version: Android 13

Any additional information?

• This is a regression from 122 where the 'Install' button worked for the same site (and same device).
• The manifest is fetched in both cases but the browser affordance doesn't update.

Comment 1

[Jonathan Almeida [:jonalmeida]]

It seems like the regression might be that we've changed the PWA affordance in bug 1885563.

Comment 2

[BugBot [:suhaib / :marco]]

:gl, since you are the author of the regressor, bug 1885563, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Jonathan Almeida [:jonalmeida]]

Based on an offline discussion with emilyw and cpeterson, we don't want to revert the previous changes because 'install' is a concept that is difficult to explain to the user what it is doing. A good compromise that emilyw suggested was to use 'Add app to homescreen'.

These are the two states that we want to cover:

1. If the user wants to add a website to the homescreen, the text will say Add to homescreen.
2. If the user wants to add a PWA to the homescreen, the text will say Add app to homescreen.

Comment 5

[Chris Peterson [:cpeterson]]

Adding this bug to our menu redesign blockers (meta bug 1898393) because we should fix the menu name for both the current and new menu design.

Comment 6

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Sanchaai [:sanchaai]]

Attachment: Bug 1906681 - Add "Add app to Home screen" menu item when PWA is detected. r=gl

Both the current and new menu should display an "Add app to homescreen" menu item if the site can be added to the homescreen as a PWA.

Figma for new menu: https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=16585-137621&t=q4Tbc8EJllfh5xF0-4

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Hey gl, there's a patch waiting on review here to fix this - do we want to move forward with it?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77b83927a5ee
Add "Add app to Home screen" menu item when PWA is detected. r=android-reviewers,giorga

Comment 11

[Aaron Train [:aaronmt]]

Hey folks, on auto-land this is triggering 6 UI test failures and identified this as the regressor. On the Phab's Try run, I see the failing job identified https://treeherder.mozilla.org/jobs?repo=try&revision=4f8c43fd09e230d905204d7baed3f0c2f315575b&selectedTaskRun=A8Utt-OuRl-Z5JDuo1mzhw.0 which have been accidently missed as part of review. Our team can take a look in the morning if Sanchaai doesn't get to it before.

E.g, https://console.firebase.google.com/u/1/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/8939745485411927409/details?stepId=bs.61edc7c3bc3f127e&testCaseId=6

• appLikeExperiencePWATest (probably needs a new resource string reference)
• externalLinkPWATest (probably needs a new resource string reference)
• installPWAFromTheMainMenuTest (probably needs a new resource string reference)
• verifyEmailLinkTest (seeing a new open in app modal prompt)
• verifyTelephoneLinkTest (seeing a new open in app modal prompt)

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/77b83927a5ee