Closed Bug 1907212 Opened 7 months ago Closed 7 months ago

Split large CloseTabs commands into multiple sends

Categories

(Firefox :: Sync, task)

task

Tracking

()

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: skhamis, Assigned: skhamis)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsync-])

Attachments

(1 file, 2 obsolete files)

There are scenarios where a user could easily hit the 16kb payload limit trying to close a large amount of tabs. Since we don't limit how many tabs they can close, we should simply split all the queued commands over multiple sends. We do something similar in the tabs engine https://searchfox.org/mozilla-central/source/services/sync/modules/engines/tabs.sys.mjs#424 where we pack as many tabs for the user as possible so they can sync all the tabs. We should do something similar here.

Assignee: nobody → skhamis
Status: NEW → ASSIGNED
Attachment #9412148 - Attachment is obsolete: true
Attachment #9412149 - Attachment is obsolete: true
Whiteboard: [fxsync-]
Pushed by skhamis@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/552493040270 Split large Close Tab commands into multiple sends r=lina
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: