1907227 - Add telemetry probe for Rust ingest times

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Add a telemetry probe that counts how long each ingest takes in the Firefox Suggest Rust component.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1907227 - Add telemetry probe for Rust ingest times.

This adds a new Glean timing distribution called quick_suggest_ingest_time to
the urlbar namespace. The distribution is updated on each successful ingest. I
don't think it makes sense to record failed ingests because they would likely
skew the data.

Comment 2

[Drew Willcoxon :adw]

Attachment: request.md

Data review request for the new urlbar.quick_suggest_ingest_time timing distribution

Comment 3

[Chris H-C :chutten]

Comment on attachment 9412168 [details]
request.md

Actually, there's a new Data Review process in town. Starting May 7, all data collections in projects reviewed in Phabricator also perform data review in Phabricator: https://wiki.mozilla.org/Data_Collection#Firefox_Desktop.2C_Firefox_and_Focus_for_Android.2C_Gecko_.28from_May_7.2C_2024.29

In short, following what the Herald message says, code authors and code reviewers together determine what level of review is needed for new or expanded data collections. You might never need to fill out a data review request form again! (For instrumentation in projects reviewed in Phabricator, anyway)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2788727ae77
Add telemetry probe for Rust ingest times. r=daisuke,urlbar-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f2788727ae77

Comment 6

[Drew Willcoxon :adw]

Bug 1907696 changed the frequency that this telemetry will be recorded with, and also the expected values. Before that bug, this telemetry measured ingest of all suggestion types combined. So during ingest, it would be recorded only once, and the time that was recorded measured the total ingest of all suggestion types combined. After that bug, this telemetry measures ingest of each individual suggestion type. So during ingest, it will be recorded as many times are there are enabled suggestion types, and each recorded value will be smaller because it measures the time for only one individual suggestion type. So for example if Fakespot, Yelp, MDN, AMO, AMP, and Wikipedia are enabled, it will be recorded 6 times per ingest.